Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import MutableMapping from collections.abc instead of collections #1378

Closed
wants to merge 1 commit into from
Closed

Import MutableMapping from collections.abc instead of collections #1378

wants to merge 1 commit into from

Conversation

@JoshKarpel
Copy link
Contributor

@JoshKarpel JoshKarpel commented Feb 6, 2019

Importing the collections ABCs from collections is deprecated and will not work in Python 3.8. From the docs:

Changed in version 3.3: Moved Collections Abstract Base Classes to the collections.abc module. For backwards compatibility, they continue to be visible in this module through Python 3.7. Subsequently, they will be removed entirely.

This PR checks for the Python version being >=3.3 and imports MutableMapping from collections.abc instead of collections if it is.

(Fixed version of PR #1377, apologies)

@jsevedge
Copy link

@jsevedge jsevedge commented May 16, 2019

Any chance of getting this reviewed and merged in by a maintainer?

@JoshKarpel @bitprophet

@bitprophet
Copy link
Member

@bitprophet bitprophet commented May 31, 2019

Nice, thank you! Will see about backporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants