Remove duplicate code. #169

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@abhinav-upadhyay
Contributor

Use the previously unused variable (file_size) and avoid calling os.stat twice.

@abhinav-upadhyay abhinav-upadhyay Avoid repeated calls to os.stat().
Use the previously unused variable (file_size) and avoid duplicate code.
cfb17ef
@abhinav-upadhyay
Contributor

Hi @bitprophet ,

I would appreciate if you pulled this request up. :)

@abhinav-upadhyay
Contributor

Ping?

@bitprophet
Member

Thanks, nice catch! Will merge next time I do a merge sprint. (Soon; digging out of triage now :))

@abhinav-upadhyay
Contributor

Thanks, waiting for it :)

@bitprophet bitprophet added Support and removed Ready for review labels Aug 11, 2014
@bitprophet bitprophet added this to the 1.12.5 et al milestone Aug 11, 2014
@bitprophet
Member

Welp that was quite the wait :( good thing this was refactoring only, sigh. Manually made the change since the code moved around some in the interim. Thanks again!

@bitprophet bitprophet closed this Aug 26, 2014
@bitprophet bitprophet added a commit that referenced this pull request Aug 26, 2014
@bitprophet bitprophet Minor refactor, re #169 ab8ea17
@bitprophet bitprophet added a commit that referenced this pull request Aug 26, 2014
@bitprophet bitprophet Changelog re #169 87f6f56
@abhinav-upadhyay abhinav-upadhyay deleted the abhinav-upadhyay:remove-duplicate-code branch Aug 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment