New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate code. #169

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@abhinav-upadhyay
Contributor

abhinav-upadhyay commented May 22, 2013

Use the previously unused variable (file_size) and avoid calling os.stat twice.

Avoid repeated calls to os.stat().
Use the previously unused variable (file_size) and avoid duplicate code.
@abhinav-upadhyay

This comment has been minimized.

Contributor

abhinav-upadhyay commented Jul 2, 2013

Hi @bitprophet ,

I would appreciate if you pulled this request up. :)

@abhinav-upadhyay

This comment has been minimized.

Contributor

abhinav-upadhyay commented Sep 5, 2013

Ping?

@bitprophet

This comment has been minimized.

Member

bitprophet commented Oct 16, 2013

Thanks, nice catch! Will merge next time I do a merge sprint. (Soon; digging out of triage now :))

@abhinav-upadhyay

This comment has been minimized.

Contributor

abhinav-upadhyay commented Oct 16, 2013

Thanks, waiting for it :)

@bitprophet

This comment has been minimized.

Member

bitprophet commented Aug 26, 2014

Welp that was quite the wait :( good thing this was refactoring only, sigh. Manually made the change since the code moved around some in the interim. Thanks again!

@bitprophet bitprophet closed this Aug 26, 2014

bitprophet added a commit that referenced this pull request Aug 26, 2014

bitprophet added a commit that referenced this pull request Aug 26, 2014

@abhinav-upadhyay abhinav-upadhyay deleted the abhinav-upadhyay:remove-duplicate-code branch Aug 26, 2014

dkhapun pushed a commit to cyberx-labs/paramiko that referenced this pull request Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment