SSHClient: Allow to use ECDSA private keys. #218

Merged
merged 2 commits into from Sep 6, 2014

Projects

None yet

2 participants

@aszlig
Contributor
aszlig commented Oct 2, 2013

Nowadays, ECDSA keys became more widespread, so it might be a good idea to support those private keys as well, especially because the change to Paramiko shouldn't be too dramatic.

aszlig added some commits Oct 2, 2013
@aszlig aszlig SSHClient: Allow to use ECDSA private keys.
Nowadays, ECDSA keys became more widespread, so it might be a good idea
to support those private keys as well.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
c702382
@aszlig aszlig SSHClient: Also look for id_ecdsa in ~/.ssh.
I'm not using keys in ~/.ssh at all, so I missed adding ECDSA support
there as well.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
ad33bb1
@aszlig aszlig added a commit to NixOS/nixpkgs that referenced this pull request Oct 2, 2013
@aszlig aszlig python-paramiko: Add patch for ECDSA private keys.
This patch should be backwards-incompatible and is also submitted
upstream as paramiko/paramiko#218.

The main reason for this patch is that we need it for NixOS/nixops#124
in order to cope with NixOS/nixops@a2718b6, which makes ECDSA private
key the default for new deployments.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
58fdf34
@bitprophet
Member

Thanks! Will review soon but looks good at a glance.

@bitprophet bitprophet added this to the 1.15 milestone Aug 11, 2014
@bitprophet
Member

Looking into this now, tried adding a test for it, and funny story, looks like the test suite doesn't actually prove any keys really work (in a real connect/authenticate manner) besides DSA. This took way too long to figure out 😠

@bitprophet bitprophet merged commit ad33bb1 into paramiko:master Sep 6, 2014

1 check passed

default The Travis CI build passed
Details
@bitprophet bitprophet added a commit that referenced this pull request Sep 6, 2014
@bitprophet bitprophet Changelog re #218 89a8ef5
@stacywsmith stacywsmith added a commit to stacywsmith/ncclient that referenced this pull request Sep 23, 2016
@stacywsmith stacywsmith Add support for ECDSA private keys.
These keys are supported in paramiko 1.15.0 and higher via #218
paramiko/paramiko#218
7399722
@stacywsmith stacywsmith referenced this pull request in ncclient/ncclient Sep 23, 2016
Merged

Add support for ECDSA private keys. #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment