Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSHClient: Allow to use ECDSA private keys. #218

Merged
merged 2 commits into from Sep 6, 2014

Conversation

@aszlig
Copy link
Contributor

@aszlig aszlig commented Oct 2, 2013

Nowadays, ECDSA keys became more widespread, so it might be a good idea to support those private keys as well, especially because the change to Paramiko shouldn't be too dramatic.

aszlig added 2 commits Oct 2, 2013
Nowadays, ECDSA keys became more widespread, so it might be a good idea
to support those private keys as well.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
I'm not using keys in ~/.ssh at all, so I missed adding ECDSA support
there as well.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
aszlig added a commit to NixOS/nixpkgs that referenced this pull request Oct 2, 2013
This patch should be backwards-incompatible and is also submitted
upstream as paramiko/paramiko#218.

The main reason for this patch is that we need it for NixOS/nixops#124
in order to cope with NixOS/nixops@a2718b6, which makes ECDSA private
key the default for new deployments.

Signed-off-by: aszlig <aszlig@redmoonstudios.org>
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Oct 17, 2013

Thanks! Will review soon but looks good at a glance.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Sep 5, 2014

Looking into this now, tried adding a test for it, and funny story, looks like the test suite doesn't actually prove any keys really work (in a real connect/authenticate manner) besides DSA. This took way too long to figure out 😠

@bitprophet bitprophet merged commit ad33bb1 into paramiko:master Sep 6, 2014
1 check passed
1 check passed
@bitprophet
default The Travis CI build passed
Details
bitprophet added a commit that referenced this pull request Sep 6, 2014
bitprophet added a commit that referenced this pull request Sep 6, 2014
stacywsmith added a commit to stacywsmith/ncclient that referenced this pull request Sep 23, 2016
These keys are supported in paramiko 1.15.0 and higher via ncclient#218
paramiko/paramiko#218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants