New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #193 (use RtlMoveMemory instead of msvcrt.memcpy) #230

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@akx
Contributor

akx commented Oct 25, 2013

This short patch seems to fix the illegal call of msvcrt.memcpy that was introduced between 1.10.1 and 1.11 by replacing it with the underlying kernel32.RtlMoveMemory call.

In addition, a little bit of sanity checking is added to make sure writes aren't out of bounds.

Refs #193.

Test case

This throws an exception on 1.11.0 and subsequent versions, doesn't with this patch applied.

from paramiko.agent import Agent
for key in Agent().get_keys():
    print key.get_name(), key.get_base64()
@bitprophet

This comment has been minimized.

Member

bitprophet commented Jan 21, 2014

Cherry-picked, plz see #193 for more :)

@bitprophet bitprophet closed this Jan 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment