Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logging level of "Secsh channel" logs #234

Merged
merged 1 commit into from Sep 6, 2014

Conversation

@dpursehouse
Copy link
Contributor

@dpursehouse dpursehouse commented Nov 15, 2013

Log "Secsh channel %d opened" with level DEBUG.
Log "Secsh channel %d open FAILED" with level ERROR.

Logging these with level INFO causes a lot of noise on the console
when using paramiko in an application that makes a lot of connections.

Log "Secsh channel %d opened" with level DEBUG.
Log "Secsh channel %d open FAILED" with level ERROR.

Logging these with level INFO causes a lot of noise on the console
when using paramiko in an application that makes a lot of connections.
@lndbrg
Copy link
Contributor

@lndbrg lndbrg commented Aug 14, 2014

I'm in favour of this change!

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Aug 18, 2014

Labeling as a 'feature', it's technically backwards incompatible. not so much that we'll punt till a 2.x, but certainly not something to be put out in a bugfix release :)

@bitprophet bitprophet added this to the 1.15 milestone Aug 18, 2014
@bitprophet bitprophet merged commit 5335d9d into paramiko:master Sep 6, 2014
1 check passed
1 check passed
@bitprophet
default The Travis CI build passed
Details
bitprophet added a commit that referenced this pull request Sep 6, 2014
@dpursehouse dpursehouse deleted the dpursehouse:secsh-channel-log-level branch Sep 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants