Handle Windows CRLF correctly in config files; fixes fabric/fabric#1023 #239

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@swenson
swenson commented Dec 2, 2013

The standard SSH clients correctly ignore CRLFs in SSH config files, but we do not trim them out.

This patches the config file parser to trim those out of the lines we read from the config file (and adds a test).

This fixes fabric/fabric#1023

@lndbrg
Contributor
lndbrg commented Jan 16, 2014

@bitprophet this would be good to merge to get the config file more platform independent.

@bitprophet bitprophet added the Bug label Aug 11, 2014
@bitprophet bitprophet added this to the 1.12.5 et al milestone Aug 11, 2014
@bitprophet
Member

Had to manually rejigger this to work on modern codebases, confirmed test fail/pass. Thanks!

@swenson
swenson commented Aug 26, 2014

Great! Want to close issue #1023 then?

@swenson
swenson commented Aug 26, 2014

That is, issue 1023 on fabric.

@bitprophet
Member

Good call, just did, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment