New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Windows CRLF correctly in config files; fixes fabric/fabric#1023 #239

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@swenson

swenson commented Dec 2, 2013

The standard SSH clients correctly ignore CRLFs in SSH config files, but we do not trim them out.

This patches the config file parser to trim those out of the lines we read from the config file (and adds a test).

This fixes fabric/fabric#1023

@lndbrg

This comment has been minimized.

Contributor

lndbrg commented Jan 16, 2014

@bitprophet this would be good to merge to get the config file more platform independent.

@bitprophet bitprophet added the Bug label Aug 11, 2014

@bitprophet bitprophet added this to the 1.12.5 et al milestone Aug 11, 2014

@bitprophet

This comment has been minimized.

Member

bitprophet commented Aug 26, 2014

Had to manually rejigger this to work on modern codebases, confirmed test fail/pass. Thanks!

@swenson

This comment has been minimized.

swenson commented Aug 26, 2014

Great! Want to close issue #1023 then?

@swenson

This comment has been minimized.

swenson commented Aug 26, 2014

That is, issue 1023 on fabric.

@bitprophet

This comment has been minimized.

Member

bitprophet commented Aug 26, 2014

Good call, just did, thanks!

dkhapun pushed a commit to cyberx-labs/paramiko that referenced this pull request Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment