Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSS-API / SSPI authenticated Diffie-Hellman Key Exchange and user authentication #250

Closed

Conversation

@SebastianDeiss
Copy link

@SebastianDeiss SebastianDeiss commented Jan 13, 2014

This patch implements the GSS-API / SSPI authenticated Diffie-Hellman
Key Exchange and user authentication (gssapi-keyex) with the context
established during key exchange.
In order to use this feature you need the following packages:

  • pyasn1 0.1.7
  • python-gssapi 0.4.0 (Unix)
  • pywin32 2.1.8 (Windows)

These packages are not required for Paramiko, but to use GSS-API / SSPI
authenticated key exchange you need to install them manually.
This patch also contains the patch of pull request #228 which implements
"diffie-hellman-group14-sha1" key exchange.

Sebastian Deiss added 2 commits Jan 13, 2014
authentication

This patch implements the GSS-API / SSPI authenticated Diffie-Hellman
Key Exchange and user authentication (gssapi-keyex) with the context
established during key exchange.
In order to use this feature you need the following packages:
- pyasn1 0.1.7
- python-gssapi 0.4.0 (Unix)
- pywin32 2.1.8 (Windows)
These packages are not required for Paramiko, but to use GSS-API / SSPI
authenticated key exchange you need to install them manually.
This patch also contains the patch of pull request paramiko#228 which implements
"diffie-hellman-group14-sha1" key exchange.
@lndbrg
Copy link
Contributor

@lndbrg lndbrg commented Jan 16, 2014

Wow, great work. Most of it looks awesome. However, it would be great if you could make sure your multiline docstrings use double quotes " instead of single quotes '.

Loading

@lndbrg
Copy link
Contributor

@lndbrg lndbrg commented Jan 16, 2014

There have also been a lot of work of porting fabric to python3 see #236, to ease the merge of this you might want to make sure that your changes are able to run on py3 (there are a few issues right now).

Loading

@lndbrg
Copy link
Contributor

@lndbrg lndbrg commented Jan 16, 2014

This also superseeds #241 right?

Loading

@SebastianDeiss
Copy link
Author

@SebastianDeiss SebastianDeiss commented Jan 20, 2014

i changed the single quotes to double quotes in my docstrings and i am currently working on py3 support.
this patch also contains #241.

Loading

@lndbrg
Copy link
Contributor

@lndbrg lndbrg commented Jan 20, 2014

Good! It would be great if you could add something about the change in the NEWS file while you are at it (a short one line-ish summary or so).

Loading

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Feb 4, 2014

N.B. at this point please add items to sites/www/changelog.rst instead of NEWS :)

Loading

@SebastianDeiss
Copy link
Author

@SebastianDeiss SebastianDeiss commented Feb 4, 2014

OK

Loading

SebastianDeiss pushed a commit to SebastianDeiss/paramiko that referenced this issue Feb 11, 2014
authentication with Python 3 support

Add Python 3 support for the GSS-API / SSPI authenticated Diffie-Hellman
Key Exchange and user authentication. This patch supersedes pull request
paramiko#250.
Sebastian Deiss added 3 commits Feb 17, 2014
Previously an attribute error occurred or a SSHException was thrown if
the GSS-API authentication failed.
If GSS-API authentication fails now or the remote host does not support
GSS-API, paramiko tries other authentication methods.
If an GSS-API / SSPI error occurs you get a status code and an error
message, but you may also want the name of the remote host.
That's what this patch adds.
Previously GSS-API authentication (gssapi-with-mic) failed if the server
sent a userauth-banner.
@SebastianDeiss SebastianDeiss mentioned this pull request Mar 6, 2014
@lndbrg
Copy link
Contributor

@lndbrg lndbrg commented Aug 14, 2014

Superseded by #267

Loading

@lndbrg lndbrg closed this Aug 14, 2014
bitprophet added a commit that referenced this issue Sep 9, 2014
dkhapun pushed a commit to cyberx-labs/paramiko that referenced this issue Jun 7, 2018
authentication with Python 3 support

Add Python 3 support for the GSS-API / SSPI authenticated Diffie-Hellman
Key Exchange and user authentication. This patch supersedes pull request
paramiko#250.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants