Don't hash the input hostname when checking a host key if the input host... #272

Closed
wants to merge 1 commit into
from

Projects

None yet

6 participants

@sigmunau
Contributor

...name is already hashed

This happens in the loop checking if a hostkey is already loaded when
loading host key files. This reduces time to load host keys file with
about two seconds for me

@sigmunau sigmunau Don't hash the input hostname when checking a host key if the input h…
…ostname is already hashed

This happens in the loop checking if a hostkey is already loaded when
loading host key files. This reduces time to load host keys file with
about two seconds for me
1795d9b
@coveralls

Coverage Status

Coverage remained the same when pulling 1795d9b on sigmunau:fix-double-hashing into a24ca77 on paramiko:master.

@lndbrg lndbrg added the Reviewed label Mar 4, 2014
@lndbrg
Contributor
lndbrg commented Mar 4, 2014

Yes, this looks sane.

@conkiztador
Contributor

This is a huge improvement. Can we merge this please? Along with #298 this fixes the slowdown we have with ECDSA keys.

Without fix:
real 0m7.071s
user 0m6.760s
sys 0m0.031s

With fix:
real 0m1.157s
user 0m0.841s
sys 0m0.032s

@Janrain-Colin

+1 merge

@bitprophet
Member

Somehow nobody noticed this duplicated #192, bah. Rolling that one into this one since this one's newer, will credit both parties in changelog.

@bitprophet bitprophet added this to the 1.12.5 et al milestone Aug 11, 2014
@bitprophet bitprophet added a commit that referenced this pull request Aug 26, 2014
@bitprophet bitprophet Changelog re #272 118d581
@bitprophet
Member

Dunno why github's not noticing, but this was cherry-picked into 1.13 and merged up thru master. Closing.

@bitprophet bitprophet closed this Aug 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment