New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hash the input hostname when checking a host key if the input host... #272

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@sigmunau
Contributor

sigmunau commented Feb 22, 2014

...name is already hashed

This happens in the loop checking if a hostkey is already loaded when
loading host key files. This reduces time to load host keys file with
about two seconds for me

Don't hash the input hostname when checking a host key if the input h…
…ostname is already hashed

This happens in the loop checking if a hostkey is already loaded when
loading host key files. This reduces time to load host keys file with
about two seconds for me
@coveralls

This comment has been minimized.

coveralls commented Feb 22, 2014

Coverage Status

Coverage remained the same when pulling 1795d9b on sigmunau:fix-double-hashing into a24ca77 on paramiko:master.

@lndbrg

This comment has been minimized.

Contributor

lndbrg commented Mar 4, 2014

Yes, this looks sane.

@conkiztador

This comment has been minimized.

Contributor

conkiztador commented Mar 31, 2014

This is a huge improvement. Can we merge this please? Along with #298 this fixes the slowdown we have with ECDSA keys.

Without fix:
real 0m7.071s
user 0m6.760s
sys 0m0.031s

With fix:
real 0m1.157s
user 0m0.841s
sys 0m0.032s

@Janrain-Colin

This comment has been minimized.

Janrain-Colin commented May 12, 2014

+1 merge

@bitprophet

This comment has been minimized.

Member

bitprophet commented Aug 11, 2014

Somehow nobody noticed this duplicated #192, bah. Rolling that one into this one since this one's newer, will credit both parties in changelog.

@bitprophet

This comment has been minimized.

Member

bitprophet commented Aug 26, 2014

Dunno why github's not noticing, but this was cherry-picked into 1.13 and merged up thru master. Closing.

@bitprophet bitprophet closed this Aug 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment