New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setup.cfg identifying this package as universal #290

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@alex
Contributor

alex commented Mar 21, 2014

Meaning that it's build is not system dependent. Which it's not, because it's pure python. Refs #275

Add a setup.cfg identifying this package as universal
Meaning that it's build is not system dependent. Which it's not, because it's pure python. Refs #275
@lndbrg

This comment has been minimized.

Contributor

lndbrg commented Mar 21, 2014

How does this work with our c dependency, pycrypto?

@lndbrg

This comment has been minimized.

Contributor

lndbrg commented Mar 21, 2014

(I'm new to wheels, read about them, haven't tried them).

@alex

This comment has been minimized.

Contributor

alex commented Mar 21, 2014

It doesn't affect it. This means the wheel created for paramiko is universal, they still have a normal dependecy on pycrypto.

@alex

This comment has been minimized.

Contributor

alex commented Mar 21, 2014

So it all works correctly :-)

@lndbrg

This comment has been minimized.

Contributor

lndbrg commented Mar 21, 2014

Ok, cool. I thought that the wheels actually packaged the dependencies too.

Sort of like a statically linked binary or a completely packaged venv, need to read up on it.

@alex

This comment has been minimized.

Contributor

alex commented Mar 21, 2014

Nope! :-)

@bitprophet

This comment has been minimized.

Member

bitprophet commented Mar 22, 2014

@alex does this need twine + an update to tasks.py::release or will it magically work with modern distribute/setuptools?

@alex

This comment has been minimized.

Contributor

alex commented Mar 22, 2014

This doesn't need anything else, but it doesn't result in wheels getting
uploaded either, it's just the first step.

On Fri, Mar 21, 2014 at 5:34 PM, Jeff Forcier notifications@github.comwrote:

@alex https://github.com/alex does this need twine + an update to
tasks.py::release or will it magically work with modern
distribute/setuptools?


Reply to this email directly or view it on GitHubhttps://github.com//pull/290#issuecomment-38337902
.

"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084

@bitprophet

This comment has been minimized.

Member

bitprophet commented Mar 22, 2014

Oh derp I can't read subject lines apparently :) +1 on breaking things up I guess!

@Ivoz

This comment has been minimized.

Ivoz commented Mar 22, 2014

@bitprophet all it essentially means is that when running python setup.py bdist_wheel, the wheel created will be one that indicates it can be (optimistically) install on any python, 2 or 3 (i.e its tag in the filename will be py2.py3. Previous to adding this line, the bdist_wheel command when building the wheel, will assume that it should only install on the python version it has been built with, or a higher minor version (i.e the tag when built with python 2.7 will be py27). universal = 1 should essentially be used for any project whose code is universally compatible with most pythons, 2 or 3.

@bitprophet

This comment has been minimized.

Member

bitprophet commented Mar 23, 2014

Thanks a lot for the explanation, @Ivoz :)

bitprophet added a commit that referenced this pull request Mar 23, 2014

Revert "Changelog fixes #290"
This reverts commit 270daca.

bitprophet added a commit that referenced this pull request Mar 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment