New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched hash functions from PyCrypto to hashlib. #295

Merged
merged 1 commit into from Apr 14, 2014

Conversation

Projects
None yet
3 participants
@alex
Contributor

alex commented Mar 29, 2014

There's a few advantages to this:

  1. It's probably faster, OpenSSL, which typically backs hashlib, receives far
    more attention for optimizaitons than PyCrypto.
  2. It's the first step to supporting PyPy, where PyCrypto doesn't run.
  3. Convention dictates to use the stdlib if there's not some reason not to.
Switched hash functions from PyCrypto to hashlib.
There's a few advantages to this:

1) It's probably fast, OpenSSL, which typically backs hashlib, receives far
   more attention for optimizaitons than PyCrypto.
2) It's the first step to supporting PyPy, where PyCrypto doesn't run.
@lndbrg

This comment has been minimized.

Contributor

lndbrg commented Mar 31, 2014

Yes plox!

@bitprophet bitprophet merged commit 4d3e0b7 into paramiko:master Apr 14, 2014

1 check passed

default The Travis CI build passed
Details

bitprophet added a commit that referenced this pull request Apr 14, 2014

@alex alex deleted the alex:hashlib-hashes branch Apr 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment