New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't validate points in known_hosts ECDSA keys #298

Merged
merged 1 commit into from Sep 8, 2014

Conversation

Projects
None yet
2 participants
@conkiztador
Contributor

conkiztador commented Mar 31, 2014

Point validation is really expensive and apparently unnecessary when
we already trust the keys in our known_hosts file.

With my current known_hosts file of 657 keys, this reduces the time
taken to complete a remote task in fabric from 24 seconds to 7 seconds.

This requires python-ecdsa >= 0.11.

Closes #270.

Don't validate points in known_hosts ECDSA keys
Point validation is really expensive and apparently unnecessary when
we already trust the keys in our known_hosts file.

With my current known_hosts file of 657 keys, this reduces the time
taken to complete a remote task in fabric from 24 seconds to 7 seconds.

This requires python-ecdsa >= 0.11.

Closes #270.
@bitprophet

This comment has been minimized.

Member

bitprophet commented Aug 8, 2014

Thanks for this! Note to self, as it modifies package requirements, it should be part of 1.15 and not released as a bugfix.

@bitprophet bitprophet added this to the 1.15 milestone Aug 11, 2014

@bitprophet bitprophet added the Bug label Sep 8, 2014

@bitprophet bitprophet merged commit 77b1aac into paramiko:master Sep 8, 2014

1 check passed

default The Travis CI build passed
Details

bitprophet added a commit that referenced this pull request Sep 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment