Don't validate points in known_hosts ECDSA keys #298

Merged
merged 1 commit into from Sep 8, 2014

Projects

None yet

2 participants

@conkiztador
Contributor

Point validation is really expensive and apparently unnecessary when
we already trust the keys in our known_hosts file.

With my current known_hosts file of 657 keys, this reduces the time
taken to complete a remote task in fabric from 24 seconds to 7 seconds.

This requires python-ecdsa >= 0.11.

Closes #270.

@conkiztador conkiztador Don't validate points in known_hosts ECDSA keys
Point validation is really expensive and apparently unnecessary when
we already trust the keys in our known_hosts file.

With my current known_hosts file of 657 keys, this reduces the time
taken to complete a remote task in fabric from 24 seconds to 7 seconds.

This requires python-ecdsa >= 0.11.

Closes #270.
77b1aac
@bitprophet
Member

Thanks for this! Note to self, as it modifies package requirements, it should be part of 1.15 and not released as a bugfix.

@bitprophet bitprophet added this to the 1.15 milestone Aug 11, 2014
@bitprophet bitprophet added the Bug label Sep 8, 2014
@bitprophet bitprophet merged commit 77b1aac into paramiko:master Sep 8, 2014

1 check passed

default The Travis CI build passed
Details
@bitprophet bitprophet added a commit that referenced this pull request Sep 8, 2014
@bitprophet bitprophet Changelog re #298 b36b87c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment