Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Transport.active to False early in Transport.__init__. #312

Closed
wants to merge 1 commit into from
Closed

Set Transport.active to False early in Transport.__init__. #312

wants to merge 1 commit into from

Conversation

@simonpercivall
Copy link
Contributor

@simonpercivall simonpercivall commented Apr 15, 2014

An exception in Transport.init will cause its repr to raise an AttributeError, which especially causes issues for error reporting that shows locals for the stack (e.g. Sentry or Django emails).

Moving self.active = False higher in Transport.init would fix this.

@bitprophet bitprophet added this to the 1.12.5 et al milestone Aug 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants