Set Transport.active to False early in Transport.__init__. #312

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@simonpercivall
Contributor

An exception in Transport.init will cause its repr to raise an AttributeError, which especially causes issues for error reporting that shows locals for the stack (e.g. Sentry or Django emails).

Moving self.active = False higher in Transport.init would fix this.

@bitprophet bitprophet added this to the 1.12.5 et al milestone Aug 11, 2014
@bitprophet bitprophet added a commit that referenced this pull request Aug 26, 2014
@bitprophet bitprophet Changelog re #312, closes #312 c7ffe17
@bitprophet bitprophet added a commit that closed this pull request Aug 26, 2014
@bitprophet bitprophet Changelog re #312, closes #312 c7ffe17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment