Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix ecdsa key generation #335
This looks like a significant change (despite its size) - as far as I can tell folks have been using ECDSA support since it was implemented, and this feels like it could break that. Can you provide a concrete test case (real test, or even just an explanation of how to manually test) proving that the code is broken without this change? Thanks!
@bitprophet hello self, I just looked in detail and the line in question is within
So yea, I'm on board with this now. Still need to test it out (& probably add tests - when I was grepping I saw tests of the other key types' generate methods but not this one) unless @lndbrg did already.