Allow setting of SSH banner timeouts on Clients #362

Merged
merged 3 commits into from Sep 8, 2014

Projects

None yet

4 participants

@Lukasa
Contributor
Lukasa commented Jul 24, 2014

This pull request contains a proposed interface for setting the SSH banner timeouts on Paramiko Client objects.

I've been working on using Paramiko as part of an integration testing tool for Project Calico. As part of this tool we frequently reset VMs back to snapshots, which can lead to quite long timeouts where the TCP connection is accepted but the SSH daemon is not yet ready to present the banner. These timeouts are frequently more than 15 seconds.

For this reason, it would be useful to be able to set the banner timeout on the underlying Transport.

Notes

  1. This pull request doesn't contain any tests. I wasn't overly concerned, given that I'm just setting a pre-existing value, but if you'd like a test for this I can write one.
  2. This is one of a number of possible APIs for setting this value, I'm open to others if you don't like the style.
@coveralls

Coverage Status

Coverage decreased (-0.13%) when pulling 2ee8ec8 on Lukasa:banner_timeout into e811e71 on paramiko:master.

@bitprophet bitprophet referenced this pull request Aug 8, 2014
Closed

about timeout #333

@lndbrg
Contributor
lndbrg commented Aug 14, 2014

@Lukasa i like this, but would prefer some tests, if you add them i'd slap on the reviewed label.

@Lukasa
Contributor
Lukasa commented Aug 14, 2014

@lndbrg Added a proposed test. =)

@coveralls

Coverage Status

Coverage increased (+0.23%) when pulling 3b9eaef on Lukasa:banner_timeout into e811e71 on paramiko:master.

@lndbrg
Contributor
lndbrg commented Aug 14, 2014

@Lukasa awesome. Can we turn it down to one second to speed up the test even more? Else, looks good.

@lndbrg lndbrg added Reviewed and removed Tests needed labels Aug 14, 2014
@coveralls

Coverage Status

Coverage increased (+0.27%) when pulling 021160d on Lukasa:banner_timeout into e811e71 on paramiko:master.

@Lukasa
Contributor
Lukasa commented Aug 14, 2014

Done. =)

@bitprophet bitprophet added this to the 1.15 milestone Aug 18, 2014
@bitprophet bitprophet merged commit 021160d into paramiko:master Sep 8, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@bitprophet bitprophet added a commit that referenced this pull request Sep 8, 2014
@bitprophet bitprophet Changelog re #362 9c9dcaf
@Lukasa
Contributor
Lukasa commented Sep 9, 2014

🐥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment