New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support py3.4 #371

Merged
merged 2 commits into from Aug 25, 2014

Conversation

Projects
None yet
3 participants
@lndbrg
Contributor

lndbrg commented Aug 14, 2014

No description provided.

lndbrg added some commits Aug 14, 2014

Join the threads with a low timeout.
Instead of using private methods on the threading class, let the
thread join, but with a low timeout.
@coveralls

This comment has been minimized.

coveralls commented Aug 14, 2014

Coverage Status

Coverage remained the same when pulling 075f5c0 on lndbrg:fix-python-threading-for-3.4 into 991d56b on paramiko:master.

@lndbrg lndbrg added Bug labels Aug 14, 2014

thread._Thread__stop()
else:
thread._stop()
thread.join(timeout=1)

This comment has been minimized.

@bitprophet

bitprophet Aug 18, 2014

Member

How is this related to adding 3.4 support?

This comment has been minimized.

@lndbrg

lndbrg Aug 18, 2014

Contributor

The _stop method changed in 3.4 breaking most if not all used of _stop. The motivation for breaking it was that it was already broken anyway and that you shouldn't rely on underscore methods anyway.

TL;DR: _stop does not stop a thread and does not work as before in 3.4

This comment has been minimized.

@bitprophet

bitprophet Aug 25, 2014

Member

Huh. Well, as long as the tests still complete OK on all interpreters I guess I don't care :) just funny that we were apparently using a broken function in the past?

@bitprophet bitprophet added Support and removed Bug labels Aug 25, 2014

@bitprophet bitprophet added this to the 1.15 milestone Aug 25, 2014

@bitprophet bitprophet merged commit 075f5c0 into paramiko:master Aug 25, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

bitprophet added a commit that referenced this pull request Aug 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment