Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window and packet fixes #372

Merged
merged 12 commits into from Sep 8, 2014
Merged

Window and packet fixes #372

merged 12 commits into from Sep 8, 2014

Conversation

@lndbrg
Copy link
Contributor

@lndbrg lndbrg commented Aug 14, 2014

This should fix #175, and also bring us closer to the rfc: http://www.ietf.org/rfc/rfc4254.txt

It changes the default sizes for window and packet in accordance to what openssh is doing. It also adds a few more constants and exposes the possibility to set window and paket sizes through the api in several places.

lndbrg added 11 commits Aug 13, 2014
Update tests to match the new numbers.
This is to indicate that they should be seen as defaults and can
be overriden.
This change adds two new parameters to the constructor of the
Transport class. Letting the user set the default windows size and
default max packet size for the instance.
Also update the documentation about values and the adverse effects
that changing them might create.
Centralise them to the common module to avoid import cycles.
Also add constants for default values and use them in the
transport class.
@coveralls
Copy link

@coveralls coveralls commented Aug 14, 2014

Coverage Status

Coverage decreased (-0.09%) when pulling c45b392 on lndbrg:window-and-packet-fixes into 991d56b on paramiko:master.

@coveralls
Copy link

@coveralls coveralls commented Aug 14, 2014

Coverage Status

Coverage decreased (-0.06%) when pulling b0ffd7c on lndbrg:window-and-packet-fixes into 991d56b on paramiko:master.

@lndbrg lndbrg added the Feature label Aug 14, 2014
@bitprophet bitprophet added this to the 1.15 milestone Aug 14, 2014
@bitprophet bitprophet merged commit b0ffd7c into paramiko:master Sep 8, 2014
1 check passed
1 check passed
@lndbrg
continuous-integration/travis-ci The Travis CI build passed
Details
bitprophet added a commit that referenced this pull request Sep 8, 2014
@bitprophet bitprophet mentioned this pull request Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants