Window and packet fixes #372

merged 12 commits into from Sep 8, 2014


None yet

3 participants

lndbrg commented Aug 14, 2014

This should fix #175, and also bring us closer to the rfc:

It changes the default sizes for window and packet in accordance to what openssh is doing. It also adds a few more constants and exposes the possibility to set window and paket sizes through the api in several places.

lndbrg added some commits Aug 13, 2014
@lndbrg lndbrg Change window and packet size to match opensshs'.
Update tests to match the new numbers.
@lndbrg lndbrg Rename max_packet_size and window_size.
This is to indicate that they should be seen as defaults and can
be overriden.
@lndbrg lndbrg Add possibility to set default sizes.
This change adds two new parameters to the constructor of the
Transport class. Letting the user set the default windows size and
default max packet size for the instance.
@lndbrg lndbrg Support specyfiying window/packet size per session
Also update the documentation about values and the adverse effects
that changing them might create.
@lndbrg lndbrg Expose the ability to set window/packet for sftp. 72c6b5c
@lndbrg lndbrg Whitespace fixes. e4e499f
@lndbrg lndbrg Bump the MIN_PACKET_SIZE to what's in the RFC. 05d2b42
@lndbrg lndbrg Add a MAX_WINDOW_SIZE constant. b5c537c
@lndbrg lndbrg Add a utility method for value clamping. 2dec0a7
@lndbrg lndbrg Add sanitation methods for window and packet size. c0df755
@lndbrg lndbrg Move window and packet constants.
Centralise them to the common module to avoid import cycles.
Also add constants for default values and use them in the
transport class.

Coverage Status

Coverage decreased (-0.09%) when pulling c45b392 on lndbrg:window-and-packet-fixes into 991d56b on paramiko:master.


Coverage Status

Coverage decreased (-0.06%) when pulling b0ffd7c on lndbrg:window-and-packet-fixes into 991d56b on paramiko:master.

@lndbrg lndbrg added the Feature label Aug 14, 2014
@bitprophet bitprophet added this to the 1.15 milestone Aug 14, 2014
@bitprophet bitprophet merged commit b0ffd7c into paramiko:master Sep 8, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
@bitprophet bitprophet added a commit that referenced this pull request Sep 8, 2014
@bitprophet bitprophet Changelog re #372 88d932f
This was referenced Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment