Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing method of hosts in ssh_config. #431

Closed
wants to merge 1 commit into from
Closed

Improve parsing method of hosts in ssh_config. #431

wants to merge 1 commit into from

Conversation

@ykalchevskiy
Copy link
Contributor

@ykalchevskiy ykalchevskiy commented Nov 10, 2014

There is a module in standard library for such parsing -- shlex.

There is a module in standard library for such parsing -- shlex.
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Nov 12, 2014

Thanks, seems legit. If it's not legit, then we don't have enough tests, but I remember more being added when this parsing change was put in a while back.

@bitprophet bitprophet added this to the 1.15.2 et al milestone Nov 12, 2014
@ykalchevskiy
Copy link
Contributor Author

@ykalchevskiy ykalchevskiy commented Nov 13, 2014

The previous parsing code was also written by me. Current tests (https://github.com/paramiko/paramiko/blob/master/tests/test_util.py#L357) are suitable.

@lndbrg
Copy link
Contributor

@lndbrg lndbrg commented Nov 13, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants