New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFTP: Add support for "posix-rename@openssh.com" extension for SFTP client. #471

Merged
merged 4 commits into from Jun 6, 2017

Conversation

Projects
None yet
3 participants
@mikapfl

mikapfl commented Jan 6, 2015

Hi,

this is the same feature as #65, but with docstrings and a test.

Note that at the moment, the test fails early if run against the sftp stub server, as the stub server actually uses os.rename() to implement the sftp rename, which is wrong as per the sftp spec. However, the test works if run against openssh.

Cheers,

Mika

@mikapfl

This comment has been minimized.

mikapfl commented Jan 6, 2015

Hi,

I guess I can add the SFTP server code for the stub server and the interfaces, and also make the stub server pass the non-posix-rename-test such that the tests all pass.
For the changelog/docs I'm not sure what to do.

Cheers,

Mika

@coveralls

This comment has been minimized.

coveralls commented Feb 1, 2015

Coverage Status

Coverage decreased (-1.08%) to 74.35% when pulling 65fb098 on mikapfl:posix_rename into e2aeeed on paramiko:master.

@bitprophet

This comment has been minimized.

Member

bitprophet commented Feb 4, 2015

Changelog's in sites/www/changelog.rst if you want to take a crack at it, just add new entry at top following style of the others. Otherwise I'll add one when I merge. Thanks!

@bitprophet bitprophet added this to the 2.2 milestone May 23, 2017

@bitprophet bitprophet merged commit 57394f5 into paramiko:master Jun 6, 2017

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

bitprophet added a commit that referenced this pull request Jun 6, 2017

@mikapfl mikapfl deleted the mikapfl:posix_rename branch Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment