New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo causes failure if Putty Pageant is running. #488

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@stevecohen42
Contributor

stevecohen42 commented Feb 17, 2015

Pageant connections fail due to a typo in the setter for the security agent descriptor. Fixing the typo takes care of the problem. Note that the Pageant connection is not covered in the test-cases and probably needs to be checked by hand from time-to-time due to being Windows specific.

@stevecohen42

This comment has been minimized.

Contributor

stevecohen42 commented Feb 18, 2015

This is a duplicate of #469, which was not pulled due to a missing changelog entry.

Folks should note that this is only applicable to the Windows platform and only when Putty's Pagaent is running when the Paramiko using application is run. As such automated testing via Travis CI is impractical (impossible?).

@bitprophet

This comment has been minimized.

Member

bitprophet commented Feb 27, 2015

Yea, we can't CI for Windows (nor do the core devs run Windows) so support is 2nd tier only unfortunately. Thanks for updating this, adding it to release milestone.

Note to self, need to add credit for the 2-3 different tickets involved here.

@bitprophet bitprophet added this to the 1.13.4 / 1.14.3 / 1.15.3 milestone Feb 27, 2015

@remram44

This comment has been minimized.

remram44 commented Apr 6, 2015

@bitprophet appveyor offers free CI on Windows, I use it on rpaths.

Also, I'm affected by this bug. I'll try to bisect the last working version.

@remram44

This comment has been minimized.

remram44 commented Apr 6, 2015

Caused by c5836ad (#419), between v1.15.1 and v1.15.2.

@bitprophet

This comment has been minimized.

Member

bitprophet commented Apr 6, 2015

Yea since I wrote that comment I actually had another user for another project help me set up appveyor, so I will add it to the others including paramiko once I have time :) (Like other Windows related support, though, it's never top priority, sorry :D)

@remram44

This comment has been minimized.

remram44 commented Apr 23, 2015

This is a very obvious typo that really breaks paramiko on Windows, bump

@JoelBennett

This comment has been minimized.

JoelBennett commented Apr 24, 2015

Chalk another one up for it breaking paramiko on Windows...

@remram44

This comment has been minimized.

remram44 commented Jun 7, 2015

Please? What do we have to do to see this get in?

@Russell-Jones

This comment has been minimized.

Russell-Jones commented Jun 7, 2015

I guess we need more volunteers to be core devs on Paramiko. I'd quite like to do this myself, but a) I'm not sure I've the time required b) I think I'd need to deepen my knowledge of the relevant RFCs first

My impression is that @bitprophet looks after this because it's integral to his Fabric project, but his requirements are a subset of all use cases, and he doesn't have time to do much more than keep it doing what he needs it to at the moment (Jeff, is that a fair summary?)

@remram44

This comment has been minimized.

remram44 commented Jun 7, 2015

I'm all for having more tests and a larger, more responsive development team. But here we've had the fix for four months, it's a two lines long, and it's just sitting in a pull request waiting for someone to press the button. The work is done. Am I going to have to merge this and vendor it in my software?

@jaraco

This comment has been minimized.

Contributor

jaraco commented Jun 7, 2015

I'd be happy to help cut releases if @bitprophet would be willing to add me as an author/maintainer.

@bitprophet

This comment has been minimized.

Member

bitprophet commented Jun 11, 2015

I'm still figuring out the situation re: giving other folks commit bits.

Re: recent time allocation, have been focusing on Fabric v2 to the exclusion of most else, but that time is nearly done and I will be going through the release milestones here (note that this ticket is in the bugfix milestone!) real soon now.

@shellster

This comment has been minimized.

shellster commented Jul 16, 2015

I'd also like to add a plea that this gets merged as soon as possible.
The fix works and is necessary for using paramiko in Windows environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment