Various GSSAPI fixes #496

Merged
merged 5 commits into from Sep 30, 2015

Projects

None yet

5 participants

@akruis
Contributor
akruis commented Mar 3, 2015

The GSSAPI support in 1.15 and master contains a few minor bugs.

  • paramiko/auth_handler.py uses MSG_NAMES without importing it.
  • The documentation of of the return value and exception of ssh_check_mic in paramiko/ssh_gss is wrong.
  • in paramiko/auth_handler.py the variable "retval" is used uninitialised.
  • paramiko/kex_gss still uses the old PyCrypto random generator.

This pull request includes one commit for each bug.

@coveralls

Coverage Status

Coverage increased (+0.16%) to 72.71% when pulling c158db9 on akruis:1.15-gssfixes into ca0fd10 on paramiko:1.15.

@coveralls

Coverage Status

Coverage increased (+0.16%) to 72.71% when pulling c158db9 on akruis:1.15-gssfixes into ca0fd10 on paramiko:1.15.

@bitprophet bitprophet added this to the 1.13.4 / 1.14.3 / 1.15.3 milestone Mar 3, 2015
@wrouesnel

I'm running this locally - paramiko as installed from pip is broken for GSS auth at the moment. This should be a high-priority merge.

@mkomitee
mkomitee commented Sep 9, 2015

FYI, without at LEAST accepting the change in c158db9, GSSAPI support is completely broken.

@mkomitee mkomitee referenced this pull request Sep 9, 2015
Closed

Kerberos support #82

@bitprophet
Member

Referencing #584 for linkage, it's not directly related as far as I can tell (insofar as the newer GSSAPI module breaking things is not the same as this bundle of fixes) but presumably without fixing #584, many users will not be able to reap the benefits of these fixes here.

@bitprophet
Member

I don't have the ability to readily test GSSAPI functionality (would like to sometime though, ugh) but since I've got at least a few people in here saying the PR fixes it, I'm going to trust them and just-merge :)

@bitprophet
Member

Ah, #584 was a little confused, if people are actually following instructions and pip installing python-gssapi and not gssapi, there's no problem currently. Still good to have these linked tho.

@bitprophet bitprophet added a commit that referenced this pull request Sep 30, 2015
@bitprophet bitprophet Changelog re #496 8bf0301
@bitprophet bitprophet merged commit 2e4d604 into paramiko:1.15 Sep 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment