Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated vendored jaraco.windows APIs #525

Merged
merged 5 commits into from Nov 3, 2015

Conversation

@jaraco
Copy link
Contributor

@jaraco jaraco commented May 8, 2015

In this commit, I refresh the vendored _winapi.py module from its reference implementation. Merging this commit incorporates the fix for #193 and also includes (tested) fixes for #488 and #498.

It does restore the tab indentation, which makes it easier to sync the code with the reference implementation. I recommend keeping the tab indentation for that reason, though if you want to convert it to spaces, feel free to do so or ask and I can do that as a separate commit.

This PR comes against the 1.13 branch as I wanted to make the fixes available to be back ported to that version. It should be able to be readily merged into 1.14, 1.15, and master by simply accepting the whole _winapi file.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented May 11, 2015

Thanks!

Re: tabs, I am starting to add linting to my processes for projects and I bet that might get mad about tabs eventually, but that can be handled then (& probably just told to skip).

Loading

@bitprophet bitprophet added this to the 1.13.4 / 1.14.3 / 1.15.3 milestone May 11, 2015
@bitprophet bitprophet removed this from the 1.15.3 milestone Oct 2, 2015
@bitprophet bitprophet added this to the 1.16 milestone Oct 2, 2015
@bitprophet bitprophet added this to the 1.16 milestone Oct 2, 2015
@bitprophet bitprophet removed this from the 1.15.3 milestone Oct 2, 2015
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Nov 3, 2015

Aw boo I thought we already implemented #505 and was trying to find the paramiko appveyor page. But no, I was thinking of invoke.

Tests pass for me on Unix with this merged, though, so full speed ahead...

Loading

@bitprophet bitprophet added this to the 1.13.5 milestone Nov 3, 2015
@bitprophet bitprophet removed this from the 1.16 milestone Nov 3, 2015
@bitprophet bitprophet merged commit e7808e1 into paramiko:1.13 Nov 3, 2015
1 check passed
Loading
bitprophet added a commit that referenced this issue Nov 3, 2015
@bitprophet bitprophet removed this from the 1.13.5 milestone Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants