Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare end of key file before reading it #565

Closed
wants to merge 1 commit into from
Closed

Conversation

@vogxn
Copy link
Contributor

@vogxn vogxn commented Jul 29, 2015

have been running this change for a week and haven't encountered the IndexError again.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jul 30, 2015

This is re #547, presumably? thanks!

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jul 30, 2015

Seems like a reasonable approach, if you can write a quick test that fails w/o this change and succeeds with it in place, that'd be awesome. Thanks!

@bitprophet bitprophet added this to the 1.13.4 / 1.14.3 / 1.15.3 milestone Jul 30, 2015
@bitprophet bitprophet modified the milestones: 1.15.3, 1.16 Oct 2, 2015
@bitprophet bitprophet modified the milestones: 1.15.4, 1.16 Nov 2, 2015
@bitprophet bitprophet closed this in fcacbe4 Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants