Add support of RFC 6668 #581

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@ericwb
ericwb commented Sep 3, 2015

Adds hmac-sha2-256 and hmac-sha2-512 as supported and recommended
MACs.

fixes: #580

ericwb added some commits Sep 3, 2015
@ericwb ericwb Add support of RFC 6668
Adds hmac-sha2-256 and hmac-sha2-512 as supported and recommended
MACs.

fixes: #580
3e1c2c6
@ericwb ericwb Add support of RFC 6668
Adds hmac-sha2-256 and hmac-sha2-512 as supported and recommended
MACs.

fixes: #580
96cf04e
@bitprophet
Member

Doesn't this partially duplicate #356?

@ericwb
ericwb commented Sep 8, 2015

True, there is some overlap, but looks like #356 was mostly to address the key exchange. It lacks support for sha512 which means our support of RFC 6668 is incomplete.

@bitprophet
Member

Cool, thanks for clarifying!

@ilmerovingio

+1

@bitprophet bitprophet added a commit that referenced this pull request Nov 2, 2015
@bitprophet bitprophet Update changelog closing #581 5a89ea2
@bitprophet
Member

TFW you use just slightly incorrect language re: Github commit hooks. See referencing commit above, this is in now, had to manually pull changes in due to overhauls re #356. Thanks again.

@bitprophet bitprophet closed this Nov 2, 2015
@bitprophet bitprophet modified the milestone: 1.16, 2.0 Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment