Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of RFC 6668 #581

Closed
wants to merge 2 commits into from
Closed

Add support of RFC 6668 #581

wants to merge 2 commits into from

Conversation

@ericwb
Copy link
Contributor

@ericwb ericwb commented Sep 3, 2015

Adds hmac-sha2-256 and hmac-sha2-512 as supported and recommended
MACs.

fixes: #580

ericwb added 2 commits Sep 3, 2015
Adds hmac-sha2-256 and hmac-sha2-512 as supported and recommended
MACs.

fixes: #580
Adds hmac-sha2-256 and hmac-sha2-512 as supported and recommended
MACs.

fixes: #580
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Sep 8, 2015

Doesn't this partially duplicate #356?

@ericwb
Copy link
Contributor Author

@ericwb ericwb commented Sep 8, 2015

True, there is some overlap, but looks like #356 was mostly to address the key exchange. It lacks support for sha512 which means our support of RFC 6668 is incomplete.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Sep 8, 2015

Cool, thanks for clarifying!

@guidoiaquinti
Copy link

@guidoiaquinti guidoiaquinti commented Oct 19, 2015

+1

bitprophet added a commit that referenced this pull request Nov 2, 2015
bitprophet added a commit that referenced this pull request Nov 2, 2015
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Nov 2, 2015

TFW you use just slightly incorrect language re: Github commit hooks. See referencing commit above, this is in now, had to manually pull changes in due to overhauls re #356. Thanks again.

@bitprophet bitprophet closed this Nov 2, 2015
@bitprophet bitprophet modified the milestones: 1.16, 2.0 Nov 2, 2015
dkhapun pushed a commit to cyberx-labs/paramiko that referenced this pull request Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants