Added support for aes192-ctr and aes192-cbc #604

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mchlt
mchlt commented Oct 30, 2015

I added support for aes192-ctr and aes192-cbc.

I tested the paramiko client against openssh server after setting "Ciphers aes192-ctr" and "aes192-cbc" respectively in sshd_config. Client connected fine, and confirmed the channel was indeed using aes192-ctr. Could execute command and transfer files.

Tested paramiko server by running the demo_server.py and then using the openssh client to connect to it, with option "-c aes192-ctr" or "-c aes192-cbc" respectively.

@bitprophet
Member

Neat, thanks! Mildly surprised nobody bothered adding this earlier when it's as simple as tweaking key size. (Similar to how adding SHA-2 512bit support was a couple lines on top of the work for SHA-2 256.)

@mchlt
mchlt commented Nov 2, 2015

Great! It surprised me as well :)

@bitprophet bitprophet added this to the 1.16 milestone Nov 2, 2015
@bitprophet bitprophet added the Feature label Nov 2, 2015
@bitprophet bitprophet added a commit that referenced this pull request Nov 2, 2015
@bitprophet bitprophet Port #604 to latest master 7030ad9
@bitprophet bitprophet added a commit that closed this pull request Nov 2, 2015
@bitprophet bitprophet Changelog closes #604 9a091e0
@bitprophet bitprophet closed this in 9a091e0 Nov 2, 2015
@bitprophet
Member

Had to manually apply, the changes for SHA-2 reformatted a bunch of the relevant lines. Made sure to credit in changelog. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment