Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for aes192-ctr and aes192-cbc #604

Closed
wants to merge 1 commit into from
Closed

Added support for aes192-ctr and aes192-cbc #604

wants to merge 1 commit into from

Conversation

@mchlt
Copy link

@mchlt mchlt commented Oct 30, 2015

I added support for aes192-ctr and aes192-cbc.

I tested the paramiko client against openssh server after setting "Ciphers aes192-ctr" and "aes192-cbc" respectively in sshd_config. Client connected fine, and confirmed the channel was indeed using aes192-ctr. Could execute command and transfer files.

Tested paramiko server by running the demo_server.py and then using the openssh client to connect to it, with option "-c aes192-ctr" or "-c aes192-cbc" respectively.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Nov 2, 2015

Neat, thanks! Mildly surprised nobody bothered adding this earlier when it's as simple as tweaking key size. (Similar to how adding SHA-2 512bit support was a couple lines on top of the work for SHA-2 256.)

@mchlt
Copy link
Author

@mchlt mchlt commented Nov 2, 2015

Great! It surprised me as well :)

@bitprophet bitprophet added this to the 1.16 milestone Nov 2, 2015
bitprophet added a commit that referenced this pull request Nov 2, 2015
@bitprophet bitprophet closed this in 9a091e0 Nov 2, 2015
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Nov 2, 2015

Had to manually apply, the changes for SHA-2 reformatted a bunch of the relevant lines. Made sure to credit in changelog. Thanks again!

dkhapun pushed a commit to cyberx-labs/paramiko that referenced this pull request Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants