Fix connection error-handling code on Python 3 #616

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@nchammas
nchammas commented Nov 8, 2015

Convert the dictionary view returned by errors.keys() to a list. Thanks to @edk0 for pointing this out.

Fixes #615.

@nchammas
nchammas commented Nov 8, 2015

The 3.5 build fail doesn't seem related to this PR, and likely is part of the problem described in #612.

@bitprophet
Member

UGH I was worried the Travis problems would mask real Python 3 errors, and surprise! Thanks for catching this.

@bitprophet bitprophet added this to the 1.16.1 milestone Nov 9, 2015
@nchammas nchammas changed the title from Fix connection error-handing code on Python 3 to Fix connection error-handling code on Python 3 Nov 24, 2015
@Glueon
Glueon commented Dec 21, 2015

@bitprophet what the state is this commit in? Are we waiting for you to review it or there is something we can do?

I really thought this PR is related to my bug, but posted an issue anyway. Just in case.

@bitprophet
Member

Oh, I failed to notice this got fixed in #679 which I just merged. Should be good now. Thanks!

@bitprophet bitprophet closed this Apr 24, 2016
@nchammas nchammas deleted the nchammas:patch-1 branch Apr 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment