Fix connection error-handling code on Python 3 #616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 3.5 build fail doesn't seem related to this PR, and likely is part of the problem described in #612. |
|
UGH I was worried the Travis problems would mask real Python 3 errors, and surprise! Thanks for catching this. |
nchammas
changed the title
|
@bitprophet what the state is this commit in? Are we waiting for you to review it or there is something we can do? I really thought this PR is related to my bug, but posted an issue anyway. Just in case. |
|
Oh, I failed to notice this got fixed in #679 which I just merged. Should be good now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the dictionary view returned by
errors.keys()to a list. Thanks to @edk0 for pointing this out.Fixes #615.