Make NoValidConnectionsError picklable correctly #679

Closed
wants to merge 4 commits into
from

Projects

None yet

2 participants

@mgedmin
Contributor
mgedmin commented Feb 4, 2016

Fixes #617 and therefore fabric/fabric#1429.

@mgedmin

OTOH maybe this should've been (self.__class__, (self.errors, )).

mgedmin added some commits Feb 5, 2016
@mgedmin mgedmin Fix tests on Python 3.x
(This also fixes #678.)
3f433f3
@mgedmin mgedmin Improve NoValidConnectionsError formatting
Because "Unable to connect to port 22 on  or X.X.X.X" looks seriously
_weird_ with the blank space between "on" and "or".
c2012cf
@mgedmin mgedmin Support pickling hypothetical subclasses e507690
@mgedmin
Contributor
mgedmin commented Feb 5, 2016

The new test I added started failing on Python 3.x on Travis because of #678, so I added a fix for that. I also couldn't look at that on or weirdness in the message text any more, so I fixed that too.

I've no clue about the Travis est failures due to lack of (vendored!) yaml2 on Python 2.x.

@bitprophet bitprophet added a commit that referenced this pull request Apr 24, 2016
@bitprophet bitprophet Changelog re #617, #679, #678, #685.
Also re fabric/fabric#1429 but IDK if Github will tickle that repo correctly :D
e2206bc
@bitprophet
Member
bitprophet commented Apr 24, 2016 edited

Looks like assertIn is python 2.7 specific, so I just replaced it with the old and just incredibly boring assert x in y so things work on 2.6. Shrug.

Cherry-picked back to 1.16 which is oldest affected branch. Just merged-up and pushed now. Thanks Marius!

@bitprophet bitprophet closed this Apr 24, 2016
@mgedmin
Contributor
mgedmin commented Apr 25, 2016

Thank you!

@mgedmin mgedmin deleted the mgedmin:fix-exception-pickling branch Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment