Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NoValidConnectionsError picklable correctly #679

Closed
wants to merge 4 commits into from

Conversation

@mgedmin
Copy link
Contributor

@mgedmin mgedmin commented Feb 4, 2016

Fixes #617 and therefore fabric/fabric#1429.

mgedmin
Copy link
Contributor

mgedmin commented on ad02aa0 Feb 4, 2016

OTOH maybe this should've been (self.__class__, (self.errors, )).

mgedmin added 3 commits Feb 5, 2016
Because "Unable to connect to port 22 on  or X.X.X.X" looks seriously
_weird_ with the blank space between "on" and "or".
@mgedmin
Copy link
Contributor Author

@mgedmin mgedmin commented Feb 5, 2016

The new test I added started failing on Python 3.x on Travis because of #678, so I added a fix for that. I also couldn't look at that on or weirdness in the message text any more, so I fixed that too.

I've no clue about the Travis est failures due to lack of (vendored!) yaml2 on Python 2.x.

bitprophet added a commit that referenced this issue Apr 24, 2016
Also re fabric/fabric#1429 but IDK if Github will tickle that repo correctly :D
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Apr 24, 2016

Looks like assertIn is python 2.7 specific, so I just replaced it with the old and just incredibly boring assert x in y so things work on 2.6. Shrug.

Cherry-picked back to 1.16 which is oldest affected branch. Just merged-up and pushed now. Thanks Marius!

@mgedmin
Copy link
Contributor Author

@mgedmin mgedmin commented Apr 25, 2016

Thank you!

@mgedmin mgedmin deleted the fix-exception-pickling branch Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants