Change raw_input() to input() for Python 3.x #716

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@mkowalski
Contributor

When using Python 3.x and connecting via paramiko.SSHClient().connect(host, port, user, pkey) to the server which forces two-factor authentication, function auth_interactive_dumb from transport.py is being invoked, where raw_input() is called. Of course it does not work in Python 3.x, therefore I'm changing it to input() and adding additional check for backwards compatibility with Python 2.x

@coveralls

Coverage Status

Coverage decreased (-0.03%) to 72.562% when pulling d15fbc4 on mkowalski:master into 74ba014 on paramiko:master.

@mkowalski
Contributor

Please note the CI build error is not related to the change

@bitprophet bitprophet added this to the 1.16.1 milestone Apr 25, 2016
@bitprophet bitprophet added the Bug label Apr 25, 2016
@bitprophet bitprophet added a commit that referenced this pull request Apr 25, 2016
@bitprophet bitprophet Changelog re #716, closes #716 905e4a1
@bitprophet
Member

Weird, I guess github doesn't honor 'closes' if it's not 1st on a line? Anyway, cherry picked this back to 1.16. thanks! (ps - for future reference, most things like this have hooks in paramiko.py3compat :))

@bitprophet bitprophet closed this Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment