Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change raw_input() to input() for Python 3.x #716

Closed
wants to merge 1 commit into from
Closed

Change raw_input() to input() for Python 3.x #716

wants to merge 1 commit into from

Conversation

@mkowalski
Copy link
Contributor

@mkowalski mkowalski commented Mar 31, 2016

When using Python 3.x and connecting via paramiko.SSHClient().connect(host, port, user, pkey) to the server which forces two-factor authentication, function auth_interactive_dumb from transport.py is being invoked, where raw_input() is called. Of course it does not work in Python 3.x, therefore I'm changing it to input() and adding additional check for backwards compatibility with Python 2.x

@coveralls
Copy link

@coveralls coveralls commented Mar 31, 2016

Coverage Status

Coverage decreased (-0.03%) to 72.562% when pulling d15fbc4 on mkowalski:master into 74ba014 on paramiko:master.

@mkowalski
Copy link
Contributor Author

@mkowalski mkowalski commented Mar 31, 2016

Please note the CI build error is not related to the change

@bitprophet bitprophet added this to the 1.16.1 milestone Apr 25, 2016
@bitprophet bitprophet added the Bug label Apr 25, 2016
bitprophet added a commit that referenced this issue Apr 25, 2016
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Apr 25, 2016

Weird, I guess github doesn't honor 'closes' if it's not 1st on a line? Anyway, cherry picked this back to 1.16. thanks! (ps - for future reference, most things like this have hooks in paramiko.py3compat :))

@bitprophet bitprophet closed this Apr 25, 2016
dkhapun pushed a commit to cyberx-labs/paramiko that referenced this issue Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants