Fix #559, ignore bad ecdsa key when parsing #742

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@cebrusfs
Contributor
cebrusfs commented May 9, 2016 edited

Fix #559, if the ecdsa key can not be decrypted or is corrupted, it will trigger AssertionError in the parser libarary cryptography/hazmat/backends/openssl/backend.py.
This exception should be catch and throw the SSHException instead, then the higher layer of paramiko can ignore this bad key.

For example, in client.connect(), paramiko should try all possible keys, and ignore usable keys, but it should not throw a AssertionError exception when parsing.

@bitprophet
Member

Good catch, thanks!

@bitprophet bitprophet added this to the 1.16.2 milestone May 12, 2016
@bitprophet
Member

Cherry-picked into 2.0(.3), thanks!

@bitprophet bitprophet closed this Dec 6, 2016
@bitprophet bitprophet added a commit that referenced this pull request Dec 6, 2016
@bitprophet bitprophet Changelog re #742 1366a63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment