New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #559, ignore bad ecdsa key when parsing #742

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@cebrusfs
Contributor

cebrusfs commented May 9, 2016

Fix #559, if the ecdsa key can not be decrypted or is corrupted, it will trigger AssertionError in the parser libarary cryptography/hazmat/backends/openssl/backend.py.
This exception should be catch and throw the SSHException instead, then the higher layer of paramiko can ignore this bad key.

For example, in client.connect(), paramiko should try all possible keys, and ignore usable keys, but it should not throw a AssertionError exception when parsing.

@bitprophet

This comment has been minimized.

Member

bitprophet commented May 12, 2016

Good catch, thanks!

@bitprophet bitprophet added this to the 1.16.2 milestone May 12, 2016

@bitprophet bitprophet modified the milestones: 1.16.2 / 1.17.1 / 2.0.1, 1.16.3 et al Jun 21, 2016

@bitprophet

This comment has been minimized.

Member

bitprophet commented Dec 6, 2016

Cherry-picked into 2.0(.3), thanks!

@bitprophet bitprophet closed this Dec 6, 2016

bitprophet added a commit that referenced this pull request Dec 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment