Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BestEncryption to BestAvailableEncryption #809

Closed
wants to merge 2 commits into from

Conversation

@ibuler
Copy link

@ibuler ibuler commented Aug 30, 2016

cryptography.hazmat.primitives.serialization has no class name BestEncryption

cryptography.hazmat.primitives.serialization has no class name BestEncryption
@coveralls
Copy link

@coveralls coveralls commented Aug 30, 2016

Coverage Status

Coverage decreased (-0.03%) to 74.22% when pulling 8446c9a on ibuler:master into 833d9f7 on paramiko:master.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Aug 30, 2016

Unfortunately this will break things for anybody using Cryptography 1.4! :(

I would suggest using a try/except to 'cascade' this so it first tries BestAvailableEncryption, then falls back to BestEncryption. That should mean it works on either version of Cryptography. Thanks!

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Aug 30, 2016

Note to self: we'll probably also want to tweak our .travis.yml so it has test matrix cells for different Cryptography versions...

Add try .. except to adapt multi-version cryptography
@coveralls
Copy link

@coveralls coveralls commented Aug 31, 2016

Coverage Status

Coverage decreased (-0.09%) to 74.161% when pulling 4a1b179 on ibuler:master into 833d9f7 on paramiko:master.

@ibuler
Copy link
Author

@ibuler ibuler commented Aug 31, 2016

Add try except , but I see Cryptography have no version use BestEncryption after 1.0

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Sep 8, 2016

Putting in 2.1 but it might be appropriate for a 2.0.x bugfix, depending. Will have to think about it when I get to it.

@ploxiln
Copy link
Contributor

@ploxiln ploxiln commented Feb 24, 2017

I think BestEncryption was always a typo. In cryptography-0.8 it was BestAvailableEncryption and in cryptography-0.7 neither existed as far as I can tell.

@ploxiln
Copy link
Contributor

@ploxiln ploxiln commented Feb 24, 2017

Found link in another issue :) pyca/cryptography@199dc27#diff-f567fb1e66bd7ded34d4717d684339b7R188

BestEncryption was never in a release, it was renamed in the same pull request it was introduced in

@bitprophet bitprophet modified the milestones: 2.0.x only, 2.2 Mar 1, 2017
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Mar 1, 2017

Huh, weird. And I no longer recall what gave me the impression re: 1.4.x.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jun 7, 2017

Rolling into #741 / #912.

@bitprophet bitprophet closed this Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants