New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #838

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@medecau

medecau commented Oct 30, 2016

This pull-request:

  • adds test environment for python 3.5
  • removes redundant pip command from tox.ini

Tox automates the creation of virtualenvs for each configured interpreter. Generates a package distribution according to setup.py. And finally installs that package in each environment before running the tests.

https://tox.readthedocs.io/en/latest/#what-is-tox

It is one of tox's features to also test dependencies are in place when running tests.

adds test environment for python 3.5
removes redundant pip command from tox.ini
@coveralls

This comment has been minimized.

coveralls commented Oct 30, 2016

Coverage Status

Coverage increased (+0.08%) to 74.289% when pulling 1134084 on medecau:fix_tests into 7366f96 on paramiko:master.

@bitprophet bitprophet referenced this pull request Nov 1, 2016

Closed

Pypy support #837

@bitprophet

This comment has been minimized.

Member

bitprophet commented Nov 1, 2016

Thanks for this & the other ticket!

We don't fully support the tox.ini right now; I just haven't really wanted to remove it after somebody added it 🙁 Unsure if I want to keep fielding PRs to it or remove it (or spend the time to figure out if I want to instead embrace tox after all...) - will have to think about it.


Re: PyPy (#837) - I've never explicitly tested Paramiko on PyPy, but now that we are using cryptography.io on the backend, I wonder how well it would work. (One of the crypto principals is also a PyPy developer.)

If you want to update travis.yml so it adds PyPy cells, then at least we can see how Travis+PyPy runs the PR's branch and get a sense :) if it's happy I may then just merge the whole PR.

@bitprophet

This comment has been minimized.

Member

bitprophet commented Dec 19, 2016

Cherry-picked the superceding #866 back to 1.17. Still includes Python 3.5 testing on Travis; changelog credit included. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment