New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid PacketizerTest.test_closed_3 to fail on platforms where errno.ETIME is not defined #863

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@sbz
Contributor

sbz commented Dec 14, 2016

This changes define the proper Timer expired error message instead of raising
AttributeError when errno.ETIME is not available on the platform. fixes #862

Avoid PacketizerTest.test_closed_3 to fail on platforms where errno.E…
…TIME

is not defined

This changes define the proper Timer expired error message instead of raising
AttributeError when errno.ETIME is not available on the platform. fixes #862
@coveralls

This comment has been minimized.

coveralls commented Dec 14, 2016

Coverage Status

Coverage decreased (-0.01%) to 74.305% when pulling c4ac6f0 on sbz:tests-fix-on-bsd into a6b7648 on paramiko:master.

@sbz sbz changed the title from Avoid PacketizerTest.test_closed_3 to fail on platforms where errno.E… to Avoid PacketizerTest.test_closed_3 to fail on platforms where errno.ETIME is not defined Dec 14, 2016

@bitprophet bitprophet added this to the 1.17.4 etc milestone Dec 14, 2016

@bitprophet

This comment has been minimized.

Member

bitprophet commented Dec 14, 2016

Thanks, looks good, adding to bugfix milestone!

bitprophet added a commit that referenced this pull request Feb 20, 2017

@bitprophet

This comment has been minimized.

Member

bitprophet commented Feb 20, 2017

Cherry-picked back to 1.17 on up.

@bitprophet bitprophet modified the milestone: 1.18.3 etc Feb 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment