New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in handling multiple interactive queries #895

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@seveas
Contributor

seveas commented Feb 15, 2017

If repeated interaction is needed, check_auth_interactive_response returns an InteractiveQuery object. Unfortunately a bug caused it not to be recognized, causing autheintication to fail. This fixes said bug by properly looking at the type of the returned object.

Fix bug in handling multiple interactive queries
If repeated interaction is needed, check_auth_interactive_response returns an InteractiveQuery object. Unfortunately a bug caused it not to be recognized, causing autheintication to fail. This fixes said bug by properly looking at the type of the returned object.
@coveralls

This comment has been minimized.

coveralls commented Feb 15, 2017

Coverage Status

Coverage increased (+0.03%) to 74.194% when pulling bc05109 on seveas:patch-1 into d35b67a on paramiko:master.

@bitprophet

This comment has been minimized.

Member

bitprophet commented Feb 19, 2017

Well that's certainly a 12-year-old bug. Good catch! Suspect uncaught for so long due to server mode being the uncommon use case, and then this style of auth being itself not too often used (at least, not until recent years, assuming this maps to key+TOTP and suchlike).

bitprophet added a commit that referenced this pull request Feb 19, 2017

@bitprophet

This comment has been minimized.

Member

bitprophet commented Feb 19, 2017

Cherry-picked to 1.17 on up, just in case. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment