New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending private-message in hipchat #5

Merged
merged 1 commit into from Mar 31, 2014

Conversation

Projects
None yet
2 participants
@nberger
Contributor

nberger commented Mar 30, 2014

When I run private-message on an actual hipchat connection, I get:

paraseba.eliga.bot=> (private-message hipchat mybot "nicoberger@gmail.com" "hola")

NullPointerException null keys not allowed  org.jivesoftware.smack.util.collections.AbstractReferenceMap.put (AbstractReferenceMap.java:249)

I'm looking into it.

Remove keywordize-keys. Fixes private-message
keywordize-keys was added with the intention of replacing underscores
with dashes. Like xmpp_jid -> xmpp-jid. But it just replaces strings with
keywords. Our map has keywords already, so this was doing nothing, except of
breaking private-message because we assumed xmpp_jid would be xmpp-jid

We might want to use something like https://github.com/jeremyheiler/wharf to
dasherize keyworkds with underscores.
@nberger

This comment has been minimized.

Contributor

nberger commented Mar 30, 2014

I fixed it by removing keywordize-keys and using the underscored keys on the map returned from user-details.

If we want to convert underscore keys to dashed keys (xmpp_jid -> xmpp-jid), we have to look for something else. keywordize-keys doesn't do that.

Maybe https://github.com/jeremyheiler/wharf, but I don't know if it's worth it to add another library for this.

paraseba added a commit that referenced this pull request Mar 31, 2014

Merge pull request #5 from nberger/fix-hipchat-private-message
Fix sending private-message in hipchat

@paraseba paraseba merged commit 4e7a64c into paraseba:master Mar 31, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment