-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve filter profile data #4313
Merged
Merged
Commits on Feb 22, 2024
-
filterProfileData: Mark null instead of rebuild
Previously we were rebuilding the record when we performed a filtering operation. This caused a lot of copying of data. Instead we now just mark the filtered our values as null in the array bitmap.
Configuration menu - View commit details
-
Copy full SHA for 44a9c8f - Browse repository at this point
Copy the full SHA 44a9c8fView commit details -
name old time/op new time/op delta FilterData-10 5.00ms ± 2% 0.38ms ± 1% -92.37% (p=0.000 n=10+10) name old alloc/op new alloc/op delta FilterData-10 6.28MB ± 0% 0.00MB ± 1% -99.94% (p=0.000 n=10+10) name old allocs/op new allocs/op delta FilterData-10 3.91k ± 1% 0.07k ± 2% -98.19% (p=0.000 n=10+10)
Configuration menu - View commit details
-
Copy full SHA for 0e03919 - Browse repository at this point
Copy the full SHA 0e03919View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcbdd1f - Browse repository at this point
Copy the full SHA dcbdd1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9bffaf - Browse repository at this point
Copy the full SHA a9bffafView commit details -
slice the records instead of marking as nil
This prevents us from having to skip over records later and other footguns where we Sum which accesses the data directly and ignores nulls
Configuration menu - View commit details
-
Copy full SHA for 8149004 - Browse repository at this point
Copy the full SHA 8149004View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2c6e36 - Browse repository at this point
Copy the full SHA d2c6e36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ae0838 - Browse repository at this point
Copy the full SHA 7ae0838View commit details
Commits on Feb 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9296146 - Browse repository at this point
Copy the full SHA 9296146View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.