Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve filter profile data #4313

Merged
merged 8 commits into from
Feb 26, 2024
Merged

Improve filter profile data #4313

merged 8 commits into from
Feb 26, 2024

Commits on Feb 22, 2024

  1. filterProfileData: Mark null instead of rebuild

    Previously we were rebuilding the record when we performed a filtering
    operation. This caused a lot of copying of data. Instead we now just
    mark the filtered our values as null in the array bitmap.
    thorfour committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    44a9c8f View commit details
    Browse the repository at this point in the history
  2. unit test fixes and benchmark

    name           old time/op    new time/op    delta
    FilterData-10    5.00ms ± 2%    0.38ms ± 1%  -92.37%  (p=0.000 n=10+10)
    
    name           old alloc/op   new alloc/op   delta
    FilterData-10    6.28MB ± 0%    0.00MB ± 1%  -99.94%  (p=0.000 n=10+10)
    
    name           old allocs/op  new allocs/op  delta
    FilterData-10     3.91k ± 1%     0.07k ± 2%  -98.19%  (p=0.000 n=10+10)
    thorfour committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    0e03919 View commit details
    Browse the repository at this point in the history
  3. lint

    thorfour committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    dcbdd1f View commit details
    Browse the repository at this point in the history
  4. overzealous on the release

    thorfour committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    a9bffaf View commit details
    Browse the repository at this point in the history
  5. slice the records instead of marking as nil

    This prevents us from having to skip over records later and other
    footguns where we Sum which accesses the data directly and ignores nulls
    thorfour committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    8149004 View commit details
    Browse the repository at this point in the history
  6. adjust list offsets

    thorfour committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    d2c6e36 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7ae0838 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. skip locations that are null

    thorfour committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    9296146 View commit details
    Browse the repository at this point in the history