Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to all query string in README.md #406

Closed
kitkatayama opened this issue Mar 12, 2019 · 1 comment

Comments

@kitkatayama
Copy link
Contributor

commented Mar 12, 2019

Currently, there is only URL for ko(Korean) resource under "Changing the displayed language" in README.md.

### Changing the displayed language

Change the displayed language using a query string:

E.g.: access the Korean version using the following url: http://localhost:5000/?locale=ko

For convenience to developer or translators, it is better to change as follows imo.

### Changing the displayed language

Change the displayed language using a query string:

* English: http://localhost:5000/?locale=en 
* Espanol: http://localhost:5000/?locale=es  
* Francais: http://localhost:5000/?locale=fr 
* and so on (I'll add complete list when send pull request)

It will be displayed as follows:


Changing the displayed language

Change the displayed language using a query string:


what do you think?
Regards,

@kitkatayama

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

this issue resolved by #407 , thank you for your attention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.