Removed warning in Config class #91

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@xavismeh

No description provided.

@parisholley

why would we want to use a constant vs registering a filter to change the value?

@parisholley
Owner

If you want to revisit this with passing tests, I will take a look, but your change causes tests to fail. Not to say that isn't good, could be the good is overly dependent on references, but just cant make that change right now. Also, the tests (from what I last recall) should fail if any notices are thrown. What version of PHP are you on? Is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment