Skip to content

Replace input buffer with scratch buffer #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2019
Merged

Replace input buffer with scratch buffer #129

merged 2 commits into from
Jun 25, 2019

Conversation

@ascjones
Copy link
Collaborator

@ascjones ascjones commented Jun 24, 2019 •
edited
Loading

Tested with examples/lang/erc20 - works.

Rel: paritytech/substrate#2911

@ascjones ascjones added the E-in-progress A task that is already being worked on. label Jun 24, 2019
@codecov-io
Copy link

codecov-io commented Jun 24, 2019 •
edited
Loading

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   86.44%   86.44%           
=======================================
  Files          60       60           
  Lines        4818     4818           
=======================================
  Hits         4165     4165           
  Misses        653      653

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe6902...6ed0e22. Read the comment docs.

Robbepop
Robbepop reviewed Jun 24, 2019
View reviewed changes
Copy link
Collaborator

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can be merged as soon as all checks pass and as soon as you can demonstrate that smart contracts can be deployed and run on the latest Substrate master. Just take the Erc20 token example for that.

core/src/env/srml/srml_only/impls.rs
}
buffer
}
read_scratch_buffer()
Copy link
Collaborator

@Robbepop Robbepop Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the simplicity of this change. 👍

@ascjones ascjones marked this pull request as ready for review June 25, 2019 10:58
@ascjones ascjones added A-ink_storage [ink_storage] Work Item and removed E-in-progress A task that is already being worked on. labels Jun 25, 2019
@Robbepop Robbepop merged commit 27087f2 into master Jun 25, 2019
@xlc
Copy link

xlc commented Jun 25, 2019

does this means ink master no long works with substrate v1.0?

@ascjones
Copy link
Collaborator Author

ascjones commented Jun 25, 2019

@xlc correct

@ascjones ascjones deleted the aj-input-buf branch June 25, 2019 11:43
@xlc
Copy link

xlc commented Jun 25, 2019

any plan to maintain compatibility with substrate v1.0? substrate master are discouraged to use for development due to frequent breaking changes
Related #95

@ascjones
Copy link
Collaborator Author

ascjones commented Jun 25, 2019

It's a good point. Just spoke to @Robbepop about this and we will look into implementing versioning when he returns.

Robbepop pushed a commit that referenced this pull request Jul 15, 2019
@ascjones @Robbepop
Replace input buffer with scratch buffer (#129)
2ecbf95 
* [examples] fix erc20 tests

* [core] ditch input buffer, read from scratch instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Robbepop Robbepop Robbepop left review comments

Assignees

No one assigned

Labels

A-ink_storage [ink_storage] Work Item

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ascjones @codecov-io @xlc @Robbepop