Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parity Issues 1.9.2 - Nano Ledger #7820

Closed
Flazky opened this issue Feb 6, 2018 · 23 comments

Comments

@Flazky
Copy link

commented Feb 6, 2018

I'm running:

  • Which Parity version?: 1.9.2
  • Which operating system?: Windows 10
  • How installed?: via installer
  • Are you fully synchronized?: yes
  • Which network are you connected to?: ethereum
  • Did you try to restart the node?: yes

Your issue description goes here below. Try to include actual vs. expected behavior and steps to reproduce the issue.

1)Parity client detects a connected Nano Ledger S, but is unable to confirm request throwing error "32602 invalid params: invalid type: null, expected string"

No prompt on the Nano Ledger S itself either.

2)Parity does not show Accounts list if Nano Ledger S is connected before starting the Parity Client.

@Flazky Flazky changed the title Nano Ledger Error 32602 Parity Issues 1.9.2 - Nano Ledger Feb 6, 2018
@5chdn 5chdn added this to the 1.10 milestone Feb 7, 2018
@rbutler81

This comment has been minimized.

Copy link

commented Feb 10, 2018

@Flazky

This comment has been minimized.

Copy link
Author

commented Feb 10, 2018

It is most likely an issue with the new Parity client itself. I have tried using the nano with MEW and works fine.

@5chdn 5chdn modified the milestones: 1.10, 1.11 Mar 1, 2018
@svantetobias

This comment has been minimized.

Copy link

commented Mar 11, 2018

I have the same problem in Parity 1.9.4. @5chdn you gave a hint on reddit that this should have been fixed in 1.9.4. Know anything about it? :)

@jamespic

This comment has been minimized.

Copy link

commented Mar 24, 2018

The issue looks to be that signer_confirmRequest is being called with null as a password, which the backend doesn't accept. If I inject an empty string as the password, then I can sign transactions. I can't tell whether it's going to be easier to make the backend accept null, or the front-end send send a non-null password (I don't totally grok the signer code yet).

@m5x

This comment has been minimized.

Copy link

commented Mar 26, 2018

I have the same issue with Parity 1.9.5 and Trezor. Is there some workaround? I really need to send some ethereum out...

@jamespic

This comment has been minimized.

Copy link

commented Mar 26, 2018

You can work around it with parity signer list, parity signer sign SIGNING_REQUEST_ID from the command line.

@m5x

This comment has been minimized.

Copy link

commented Mar 26, 2018

Thanks for the hint. Worked like a charm.

@ToasT-KIWI

This comment has been minimized.

Copy link

commented Apr 2, 2018

I have the same issue. It's way beyond my skills to use the command line (wherever that is). What do I do?

@jamespic

This comment has been minimized.

Copy link

commented Apr 2, 2018

@toasteruk I don't know of an easier workaround than that.

If you're on Windows or Ubuntu, you can get a command line by clicking the start menu, and typing "command line" (not sure about Mac). On Ubuntu or Mac the commands should work as-is, on Windows you may need to change to the directory you installed Parity to.

Another workaround would be to use MyEtherWallet, if it works for your use case.

@ToasT-KIWI

This comment has been minimized.

Copy link

commented Apr 2, 2018

@jamespic

This comment has been minimized.

Copy link

commented Apr 2, 2018

Funnily enough, this issue (and the more general context of the Parity UI being deprecated) prompted me to look at adding Ledger support to MetaMask. I made some progress (which I discussed on MetaMask/metamask-extension#717), but some weird architectural choices by Chrome are making it much harder than it needs to be (either Chrome or MetaMask would need to make some painful changes to their security model). It might actually be easier to write a new Chrome plugin that's Ledger-only, but I've never quite found the motivation (or time) to do so.

@ToasT-KIWI

This comment has been minimized.

Copy link

commented Apr 2, 2018

@Xiaoyang-Zhu

This comment has been minimized.

Copy link

commented Apr 17, 2018

I got the same issue on version 1.9.6? any fix patches?

@cwesystems

This comment has been minimized.

Copy link

commented Apr 17, 2018

For me Trezor now works with "Parity 1.10.1-beta". Maybe you can give that version a try?

@Tbaut

This comment has been minimized.

Copy link
Collaborator

commented Apr 18, 2018

@shane1900

This comment has been minimized.

Copy link

commented Apr 22, 2018

Same error for me even after trashing app and installing latest stable release on mac.

@jamespic

This comment has been minimized.

Copy link

commented Apr 23, 2018

@shane1900 What about 1.10.1, which is the latest beta release?

@Tbaut

This comment has been minimized.

Copy link
Collaborator

commented Apr 23, 2018

@Tbaut Tbaut closed this Apr 23, 2018
@Tbaut

This comment has been minimized.

Copy link
Collaborator

commented Apr 23, 2018

@shane1900 can you confirm it happened on v1.10.1 (and answer in the new issue)?

@Tbaut

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2018

@shane1900 Could you please try with Parity v1.10 and to connect the Ledger Nano S before launching Parity and Parity UI ?

@shane1900

This comment has been minimized.

Copy link

commented Apr 24, 2018

@Tbaut Yes that works with v1.10 thank you. I was not wanting to use the beta since previously it had not worked with Maker / Dai CDP's. Another bug though, setting custom gas did not take on the first screen. Had to edit it manually again on the confirmation popup.

@Tbaut

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2018

Thanks @shane1900, can you confirm you're on windows?

@shane1900

This comment has been minimized.

Copy link

commented Apr 25, 2018

Yes v.1.10 on windows @Tbaut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
User Interface
Awaiting triage
You can’t perform that action at this time.