Navigation Menu

Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix _cannot recursively call into Core_ - Part 2 #10195

Merged
merged 1 commit into from Jan 16, 2019
Merged

Conversation

ngotchac
Copy link
Contributor

Fixes #10185

This PR makes parity-ethereum run all igd methods in its own thread.

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jan 16, 2019
@ordian ordian added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 16, 2019
@ordian ordian added this to the 2.4 milestone Jan 16, 2019
@5chdn
Copy link
Contributor

5chdn commented Jan 16, 2019

Does this also affect 2.2?

@ngotchac
Copy link
Contributor Author

@5chdn Nope, it was introduced in #9979 which don't seem to be in v2.2.7

@5chdn 5chdn merged commit 1df6361 into master Jan 16, 2019
@5chdn 5chdn deleted the ng-fix-tokio-core-rec branch January 16, 2019 15:35
@5chdn 5chdn mentioned this pull request Jan 21, 2019
6 tasks
5chdn pushed a commit that referenced this pull request Jan 22, 2019
5chdn added a commit that referenced this pull request Jan 22, 2019
* version: bump beta to 2.3.1

* Fix _cannot recursively call into `Core`_ issue (#10144)

* Change igd to github:maufl/rust-igd

* Run `igd::search_gateway_from_timeout` from own thread

* Update for Android cross-compilation. (#10180)

* build-unix update

* .gitlab-ci update

* Update build-unix.sh

add android postprocessing

* path to android lib

libparity.so

* fix path to libparity

* add android lib to artifacts

* Run all `igd` methods in its own thread (#10195)

* Cancel Constantinople HF on POA Core (#10198)

* Add EIP-1283 disable transition (#10214)

* Enable St-Peters-Fork ("Constantinople Fix") (#10223)

* ethcore: disable eip-1283 on kovan block 10255201

* ethcore: disable eip-1283 on ropsten block 4939394

* ethcore: enable st-peters-fork on mainnet block 7280000

* ethcore: fix kovan chain spec

* version: update fork blocks

* ethcore: disable eip-1283 on sokol block 7026400
ordian added a commit that referenced this pull request Mar 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants