This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
[ethash] chainspec validate ecip1017EraRounds
non-zero
#11123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11119 for background information.
This PR does the following:
fn ecip1017_eras_block_reward
and add explicit panic forhidden
panics that may occur bydivide by zero
We could maybe just return
zero era rounds
whenecip1017EraRounds < 2
Thoughts?