Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wallet to new Wallet Code #4805

Merged
merged 24 commits into from Mar 7, 2017

Conversation

Projects
None yet
3 participants
@ngotchac
Copy link
Collaborator

ngotchac commented Mar 7, 2017

Updates the UI to use the new Wallet.
Now one can deploy contracts with a Wallet.

The Wallet Library should be deployed to any network where we want to have it.
The bytecode + ABI are in js/src/contracts/code/wallet.js : walletLibrary and walletLibraryABI.
The deployed address should then be added to the registry with walletLibrary as a key (the value of walletLibraryRegKey). It has been done for Kovan already.

@jacogr

This comment has been minimized.

Copy link
Collaborator

jacogr commented Mar 7, 2017

Will add the above instructions to my auto-deploy tool as well. (So it just gets done by click of a button) https://github.com/ethcore/parity/pull/4726

return WalletsUtils
.isWallet(api, address)
.then((isWallet) => {
if (!isWallet) {

This comment has been minimized.

@jacogr

jacogr Mar 7, 2017

Collaborator

+1 Really happy with this approach. (For both deploy & estimate)

transaction.gasUsed
? (
<span>
<span>used</span>

This comment has been minimized.

@jacogr

jacogr Mar 7, 2017

Collaborator

Would have made sense to i18n these additions, but no matter, busy with this actual file in my conversion branch, so will be ok.

if (!isEqual(localHashes, this.localHashes)) {
@action setLocalHashes = (localHashes = []) => {
// Use slice to make sure they are both Arrays (MobX uses Objects for Observable Arrays)
if (!isEqual(localHashes.slice(), this.localHashes.slice())) {

This comment has been minimized.

@jacogr

jacogr Mar 7, 2017

Collaborator

Not sure which one is more performant from a MobX perspective - .peek() or .slice() (Typically do use the former when it is a known (i.e. on this.) value

@jacogr

This comment has been minimized.

Copy link
Collaborator

jacogr commented Mar 7, 2017

Ok, happy with it from a code perspective, it needs to go for 1.6 - full end-to-end scenario testing will happen once merged.

@jacogr jacogr merged commit 4d08e7b into master Mar 7, 2017

3 checks passed

commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/gitlab-js-test Build stage: test; status: success
Details
continuous-integration/gitlab-test-rust-stable Build stage: test; status: success
Details

@jacogr jacogr deleted the ng-update-wallet branch Mar 7, 2017

jacogr added a commit that referenced this pull request Mar 7, 2017

Update Wallet to new Wallet Code (#4805)
* Update Wallet Version

* Update Wallet Library

* Update Wallets Bytecodes

* Typo

* Separate Deploy in Contract API

* Use the new Wallet ABI // Update wallet code

* WIP .// Deploy from Wallet

* Update Wallet contract

* Contract Deployment for Wallet

* Working deployments for Single Owned Wallet contracts

* Linting

* Create a Wallet from a Wallet

* Linting

* Fix Signer transactions // Add Gas Used for transactions

* Deploy wallet contract fix

* Fix too high gas estimate for Wallet Contract Deploys

* Final piece ; deploying from Wallet owned by wallet

* Update Wallet Code

* Updated the Wallet Codes

* Fixing Wallet Deployments

* Add Support for older wallets

* Linting

arkpar added a commit that referenced this pull request Mar 8, 2017

[beta] UI backports (#4809)
* Update Wallet to new Wallet Code (#4805)

* Update Wallet Version

* Update Wallet Library

* Update Wallets Bytecodes

* Typo

* Separate Deploy in Contract API

* Use the new Wallet ABI // Update wallet code

* WIP .// Deploy from Wallet

* Update Wallet contract

* Contract Deployment for Wallet

* Working deployments for Single Owned Wallet contracts

* Linting

* Create a Wallet from a Wallet

* Linting

* Fix Signer transactions // Add Gas Used for transactions

* Deploy wallet contract fix

* Fix too high gas estimate for Wallet Contract Deploys

* Final piece ; deploying from Wallet owned by wallet

* Update Wallet Code

* Updated the Wallet Codes

* Fixing Wallet Deployments

* Add Support for older wallets

* Linting

* SMS Faucet (#4774)

* Faucet

* Remove flakey button-index testing

* Only display faucet when sms verified (mainnet)

* simplify availability checks

* WIP

* Resuest from verified -> verified

* Update endpoint, display response text

* Error icon on errors

* Parse hash text response

* Use /api/:address endpoint

* hash -> data

* Adjust sms-certified message

* Fix SectionList hovering issue (#4749)

* Fix SectionList Items hover when <3 items

* Even easier...

* lint (new)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.