Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Whisper cli #8201
This is an attempt to close #6138
It's alot of work re-implement (copy-paste) them so I don't think it is worth the effort. But maybe a couple of CLI arguments tests and some
except for the small grumble, LGTM.
I noticed a very interesting bug BTW if you run:
$ whisper-cli --port=24``` (i.e, a privileged port requires root access)
The error is not always propagated I guess it has wait for all other resources to released which may not happen that could be annoying for the user who may think that
So I lean towards using
I think it is good to go now, but I had to introduce an additional variable to
Alternately we could just skip joining threads and terminate!