Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Update SF to latest spec #1386

Merged
merged 3 commits into from
Jun 22, 2016
Merged

Update SF to latest spec #1386

merged 3 commits into from
Jun 22, 2016

Conversation

gavofyork
Copy link
Contributor

@gavofyork gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label Jun 22, 2016
@openethereum openethereum locked and limited conversation to collaborators Jun 22, 2016
rphmeier
rphmeier reviewed Jun 22, 2016
View reviewed changes
ethcore/src/state.rs
return Err(Error::Transaction(TransactionError::DAORescue));
let whitelisted = if let Action::Call(to) = t.action {
to == Address::from("Da4a4626d3E16e094De3225A751aAb7128e96526") ||
to == Address::from("2ba9D006C1D72E67A70b5526Fc6b4b0C0fd6D334")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be lifted out to (lazy_static?) constants rather than perform the string -> address conversion each time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not on a known hotpath and you know what they say about premature optimisation :)

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 22, 2016
@gavofyork gavofyork merged commit 353b9e9 into master Jun 22, 2016
@gavofyork gavofyork deleted the daosfwhitelist branch June 22, 2016 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavofyork @rphmeier @arkpar