-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
Definitely better than before. Tiny details I'd change:
|
name={ name } | ||
unknown | ||
/> | ||
<div className={ styles.mainContainer }> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While mucking about - we should really use a Container for these, matches up with what we have everywhere else.
On the specific issue mentioned - the APIs are actually being changes (should have the new versions available in the morning - still needs to be reviewed/merged.) Basically in this view we will start using |
As for UI -
Apart from that, think I like it. (General comment, i.e. my comment on use of |
Okay, I updated it to take your comments into account. |
@@ -111,10 +111,16 @@ export default class AccountStore { | |||
} | |||
|
|||
subscribeDefaultAccount () { | |||
return this._api.subscribe('parity_defaultAccount', (error, defaultAccount) => { | |||
this._api.subscribe('parity_defaultAccount', (error, defaultAccount) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a reason for the return - when testing, you can call the function and do the expectations after promise has resolved. (This way you don't end up with unresolved promises or possible fragile wait-states.)
So revert and rather put the other subscription explicitly in an own function.
@@ -95,20 +94,25 @@ $modalZ: 10001; | |||
} | |||
} | |||
|
|||
.accountsSection { | |||
padding: 0 1em; | |||
width: 920px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we don't want to take up all available space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it was looking very strange when you switch from 2 accounts displayed to 3 accounts (try it out). The layout would be totally different. Here it is more consistent whatever the number of accounts to show, and it is consistent with the width of the Signer.
This is a WIP
Fixes an issue with the Signer Accounts that were not updating when adding/removing accounts to the Dapps Whitelist.
Would close #4045
Look at the playground: http://localhost:3000/#/playground
Here is what it looks like currently (the bottom tags are hovered):