Skip to content

consider refactor CliConfiguration in such way to reduce its footgun factor #2499

@xlc

Description

@xlc

Right now it have many default implementations, well, too many. This means client can miss some implementations and still everything appears to be working, until I am trying to set the config and it doesn't work.

In my particular case, I did not implement those methods for the RelayChainCli for Acala

/// Get maximum RPC request payload size.
fn rpc_max_request_size(&self) -> Result<u32> {
Ok(RPC_DEFAULT_MAX_REQUEST_SIZE_MB)
}
/// Get maximum RPC response payload size.
fn rpc_max_response_size(&self) -> Result<u32> {
Ok(RPC_DEFAULT_MAX_RESPONSE_SIZE_MB)
}

and --rpc-max-request-size and many more parameters doesn't work for the embed relaychain node in Acala.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C1-mentorA task where a mentor is available. Please indicate in the issue who the mentor could be.D1-mediumCan be fixed by a coder with good Rust knowledge but little knowledge of the codebase.I4-refactorCode needs refactoring.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions