-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Open
Labels
C1-mentorA task where a mentor is available. Please indicate in the issue who the mentor could be.A task where a mentor is available. Please indicate in the issue who the mentor could be.D1-mediumCan be fixed by a coder with good Rust knowledge but little knowledge of the codebase.Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.I4-refactorCode needs refactoring.Code needs refactoring.
Description
Right now it have many default implementations, well, too many. This means client can miss some implementations and still everything appears to be working, until I am trying to set the config and it doesn't work.
In my particular case, I did not implement those methods for the RelayChainCli for Acala
polkadot-sdk/substrate/client/cli/src/config.rs
Lines 318 to 326 in ede4a36
| /// Get maximum RPC request payload size. | |
| fn rpc_max_request_size(&self) -> Result<u32> { | |
| Ok(RPC_DEFAULT_MAX_REQUEST_SIZE_MB) | |
| } | |
| /// Get maximum RPC response payload size. | |
| fn rpc_max_response_size(&self) -> Result<u32> { | |
| Ok(RPC_DEFAULT_MAX_RESPONSE_SIZE_MB) | |
| } |
and --rpc-max-request-size and many more parameters doesn't work for the embed relaychain node in Acala.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C1-mentorA task where a mentor is available. Please indicate in the issue who the mentor could be.A task where a mentor is available. Please indicate in the issue who the mentor could be.D1-mediumCan be fixed by a coder with good Rust knowledge but little knowledge of the codebase.Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.I4-refactorCode needs refactoring.Code needs refactoring.