Skip to content

Created client for the faucet#204

Merged
Bullrich merged 31 commits intomainfrom
bullrich/web-faucet
Feb 21, 2023
Merged

Created client for the faucet#204
Bullrich merged 31 commits intomainfrom
bullrich/web-faucet

Conversation

@Bullrich
Copy link
Contributor

Created a client for the faucet.

You can test the website in http://bullrich.dev/substrate-matrix-faucet/
Enter any address to try the happy path, and write error as the address to try see how it reacts under an error.

This commit closes #203

Created GitHub Action to deploy and test the page automatically.

We still need to enable an endpoint to work for this client, and to set up a new Google Captcha account.

This project is using Google Captcha v3 as it's more friendly and less invasive.

It was developed using Svelte, Tailwind and DaisyUI.

I also added meta tags so when it's share it looks prettier.

@Bullrich Bullrich self-assigned this Feb 20, 2023
@Bullrich Bullrich requested review from a team and fevo1971 as code owners February 20, 2023 18:49
- run: npm run build
env:
VITE_CAPTCHA_KEY: 6LftP5wkAAAAAH5cbuutkYKKaTnUMTLPqWlyeIL6
VITE_FAUCET_URL: https://ink-docs-rococo-faucet.parity-testnet.parity.io/drip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is temporary right?
if that's gonna be an alternative to current westend/rococo in matrix, there should be separate instances of server with its own wallets inside. So there will be 2-3 deploy-site.yml jobs, each with its own VITE_FAUCET_URL?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: perhaps would be a bit more flexible going forward to have this as host, and /drip or /balance would be defined in the query/request methods

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I copy this from the implementation of !ink, but I need to sync with @rzadp so that we can see how we are gonna deploy it.

Also, this implementation uses captcha v3 (less invasive) while that endpoint uses captcha v2, so I think it also needs a slightly different code.

@Bullrich Bullrich requested a review from a team February 21, 2023 08:38
Copy link
Contributor

@rzadp rzadp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, except the minor comments that could be handled separately.

@Bullrich Bullrich added this to the Web Faucet milestone Feb 21, 2023
@Bullrich Bullrich enabled auto-merge (squash) February 21, 2023 12:18
@Bullrich Bullrich merged commit c08ecd6 into main Feb 21, 2023
@Bullrich Bullrich deleted the bullrich/web-faucet branch February 21, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Website faucet

4 participants

Comments