This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Ensure all parachain configuration extrinsics are operational #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
approved these changes
Sep 23, 2021
emostov
reviewed
Sep 23, 2021
#[pallet::weight(( | ||
T::WeightInfo::set_hrmp_open_request_ttl(), | ||
DispatchClass::Operational, | ||
))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems irrelevant to add it here, but also don't see the harm
emostov
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much context on this module, but looks reasonable considering they all require root origin.
bot merge |
Trying merge. |
ordian
added a commit
that referenced
this pull request
Sep 28, 2021
* master: (24 commits) Added multisig in Rococo (#3873) Fix bin-substrate toml (#3939) Bump tracing from 0.1.27 to 0.1.28 (#3937) XCM Benchmarks for Asset Transactor w/ Fungible Asset (#3818) Bump libc from 0.2.101 to 0.2.102 (#3933) Do not compile `wasm_api` module when not needed. (#3934) Bump syn from 1.0.76 to 1.0.77 (#3932) Fix spelling (#3845) Bump tokio from 1.11.0 to 1.12.0 (#3910) Ignore `generate-bags` by dependabot (#3930) Update logging in paras_inherent (#3927) Bump libsecp256k1 from 0.6.0 to 0.7.0 (#3909) Remove BEEFY repo dependency (#3923) Substrate Companion for rust 1.54 (#3807) Fix broken links (#3919) update BaseXcmWegiht to match Kusama (#3911) add parachains pallets to Polkadot runtime (#3815) Add a `force_unfreeze` extrinsic to the disputes module (#3906) Add new rococo chainspec (#3905) Ensure all parachain configuration extrinsics are operational (#3912) ...
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add
DispatchClass::Operational
to all extrinsic weights inparachain_runtime::configuration
. They were erroneously removed when benchmarks for the configuration pallet was introduced in #3862.