Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Ensure all parachain configuration extrinsics are operational #3912

Merged
1 commit merged into from
Sep 23, 2021

Conversation

KiChjang
Copy link
Contributor

@KiChjang KiChjang commented Sep 23, 2021

Re-add DispatchClass::Operational to all extrinsic weights in parachain_runtime::configuration. They were erroneously removed when benchmarks for the configuration pallet was introduced in #3862.

@KiChjang KiChjang added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Sep 23, 2021
#[pallet::weight((
T::WeightInfo::set_hrmp_open_request_ttl(),
DispatchClass::Operational,
))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems irrelevant to add it here, but also don't see the harm

Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much context on this module, but looks reasonable considering they all require root origin.

@shawntabrizi shawntabrizi added this to In progress in Runtime via automation Sep 23, 2021
@KiChjang
Copy link
Contributor Author

bot merge

@ghost
Copy link

ghost commented Sep 23, 2021

Trying merge.

@ghost ghost merged commit ec29b1a into master Sep 23, 2021
@ghost ghost deleted the kckyeung/fixup-paraconfig-weights branch September 23, 2021 06:21
Runtime automation moved this from In progress to Done Sep 23, 2021
ordian added a commit that referenced this pull request Sep 28, 2021
* master: (24 commits)
  Added multisig in Rococo (#3873)
  Fix bin-substrate toml (#3939)
  Bump tracing from 0.1.27 to 0.1.28 (#3937)
  XCM Benchmarks for Asset Transactor w/ Fungible Asset (#3818)
  Bump libc from 0.2.101 to 0.2.102 (#3933)
  Do not compile `wasm_api` module when not needed. (#3934)
  Bump syn from 1.0.76 to 1.0.77 (#3932)
  Fix spelling (#3845)
  Bump tokio from 1.11.0 to 1.12.0 (#3910)
  Ignore `generate-bags` by dependabot (#3930)
  Update logging in paras_inherent (#3927)
  Bump libsecp256k1 from 0.6.0 to 0.7.0 (#3909)
  Remove BEEFY repo dependency (#3923)
  Substrate Companion for rust 1.54 (#3807)
  Fix broken links (#3919)
  update BaseXcmWegiht to match Kusama (#3911)
  add parachains pallets to Polkadot runtime (#3815)
  Add a `force_unfreeze` extrinsic to the disputes module (#3906)
  Add new rococo chainspec (#3905)
  Ensure all parachain configuration extrinsics are operational (#3912)
  ...
@shawntabrizi shawntabrizi moved this from Done to Archive in Runtime Dec 9, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
Runtime
Archive
Development

Successfully merging this pull request may close these issues.

None yet

3 participants