Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Enable refactored authority discovery #624

Conversation

@mxinden
Copy link
Contributor

mxinden commented Nov 28, 2019

This pull request introduces the refactored version of the authority discovery module into the master branch for the Kusamam v0.7 release. The feature is gated behind the --enable-authority-discovery feature flag.

Important: This pull request replaces #601. It points at https://github.com/paritytech/polkadot/tree/fix_polkadot_for_light_tx_pool3 for now which in turn is based on #623. Once those branches are in master I can point this pull request against master as well.

mxinden added 4 commits Nov 20, 2019
Make sure existing key types don't change their order by appending the
authority discovery id instead of injecting it between im online id and
parachain validator id.
@mxinden mxinden requested review from gavofyork, jacogr and bkchr Nov 28, 2019
@parity-cla-bot

This comment has been minimized.

Copy link

parity-cla-bot commented Nov 28, 2019

It looks like @mxinden signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@jacogr

This comment has been minimized.

Copy link
Contributor

jacogr commented Nov 28, 2019

Since we are only gating the feature, i.e. the Keys struct has all 5, happy with this.

@gavofyork gavofyork merged commit 8b74b57 into paritytech:fix_polkadot_for_light_tx_pool3 Nov 28, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/gitlab-check-line-width Build stage: test; status: failed
Details
ci/gitlab/624 Pipeline passed with warnings on GitLab
Details
continuous-integration/gitlab-check-runtime Build stage: test; status: success
Details
continuous-integration/gitlab-test-linux-stable Build stage: test; status: success
Details
@mxinden

This comment has been minimized.

Copy link
Contributor Author

mxinden commented Nov 28, 2019

Since we are only gating the feature, i.e. the Keys struct has all 5, happy with this.

To make sure we are on the same page @jacogr: The additional session key is introduced both if the feature flag is enabled, as well if it is disabled.

The feature flag enables the logic of putting ones addresses on the DHT and querying the DHT for other peoples addresses.

@jacogr

This comment has been minimized.

Copy link
Contributor

jacogr commented Nov 28, 2019

100%, it would have been an issue if the key dropped in-and-out of the structure.

gavofyork added a commit that referenced this pull request Nov 28, 2019
* Update to latest Substrate master (#615)

* Update to latest Substrate master

* Remove unneeded patch + warning

* Update `Cargo.lock`

* Fix tests

* Update again

* Bump Substrate (#616)

* Update lock

* Fix

* Few fixes

* Bump to latest Substrate

* Fixes

* fix pre-tx-pool compilation

* more compilation fixes

* Updates for the injection period

- Liberal slash-refunding
- Instant unbonding

* *: Enable refactored authority discovery (#624)

* *: Enable authority discovery module

* *: List authority discovery id after parachain validator id

Make sure existing key types don't change their order by appending the
authority discovery id instead of injecting it between im online id and
parachain validator id.

* *: Gate authority discovery module behind feature flag

* cli/src/lib.rs: Fix warnings

* cli/src/lib.rs: Shorten line length

* Bump Substrate

* Bump Substrate

* Line widths

* Line widths again

* Revert bump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.