Skip to content
This repository has been archived by the owner on Sep 22, 2021. It is now read-only.

Made email, name optional #235

Merged
merged 2 commits into from Jan 27, 2020
Merged

Made email, name optional #235

merged 2 commits into from Jan 27, 2020

Conversation

niklabh
Copy link
Contributor

@niklabh niklabh commented Jan 21, 2020

closes: #233

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the following in the front-end when not using any email

Variable "$email" of type "String" used in position expecting type "String!".

@niklabh
Copy link
Contributor Author

niklabh commented Jan 27, 2020

Working fine for me.
Screenshot from 2020-01-27 12-09-33
Screenshot from 2020-01-27 12-09-19

Can you rerun migrations after dropping and recreating db.

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, there must have been something wrong with my setup.
working well.

@Tbaut Tbaut merged commit 5c9388e into master Jan 27, 2020
@Tbaut Tbaut deleted the niklabh-feature-email-optional branch January 27, 2020 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make email and name optional for signup
2 participants