Added regex validation

[Bullrich]

Created method which validates the regex expressions in a configuration.

Closes #16

I want to have a constant error type + a custom error log so I make it return either a passed status or a failed status + error message so it can be logged.

[Bullrich]

I could maybe change this to be the following:

Suggested change

	export const validateRegularExpressions = (
	config: ConfigurationFile,
	logger: ActionLogger,
	): [true] | [false, string] => {
	/** Regex evaluator */
	const isRegexValid = (regex: string): boolean => {
	try {
	new RegExp(regex);
	return true;
	} catch (e) {
	logger.error(e as Error);
	return false;
	}
	};
	for (const rule of config.rules) {
	for (const condition of rule.condition.include) {
	if (!isRegexValid(condition)) {
	return [false, `Include condition '${condition}' is not a valid regex`];
	}
	}
	if (rule.condition.exclude) {
	for (const condition of rule.condition.exclude) {
	if (!isRegexValid(condition)) {
	return [false, `Exclude condition '${condition}' is not a valid regex`];
	}
	}
	}
	}
	return [true];
	};
	export const validateRegularExpressions = (
	config: ConfigurationFile,
	logger: ActionLogger,
	): boolean => {
	/** Regex evaluator */
	const isRegexValid = (regex: string): boolean => {
	try {
	new RegExp(regex);
	return true;
	} catch (e) {
	logger.error(e as Error);
	return false;
	}
	};
	for (const rule of config.rules) {
	for (const condition of rule.condition.include) {
	if (!isRegexValid(condition)) {
	logger.error(`Include condition '${condition}' is not a valid regex`);
	return false;
	}
	}
	if (rule.condition.exclude) {
	for (const condition of rule.condition.exclude) {
	if (!isRegexValid(condition)) {
	logger.error(`Exclude condition '${condition}' is not a valid regex`);
	return false;
	}
	}
	}
	}
	return true;
	};

what do you think?

[mutantcornholio]

Maybe instead of Regular expression is invalid. Check the logs, do

throw new Error(`Regular expression is invalid: ${error.message}`);

?

We wouldn't expect anything aside from descriptive error there, right? (because, there's nothing going on except compiling the regex).

Or, leave it like this, it's good enough already.

[Bullrich]

Yeah, it makes sense. I don't need to capture the state, only validate that it works or fail.

It also makes it easier for testing